Conversation
toddbaert
requested review from
agardnerIT,
beeme1mr,
james-milligan and
thomaspoignant
toddbaert
force-pushed
the
flagd-web
branch
3 times, most recently
from
3faa4e0 to
70e9616
Compare
toddbaert
force-pushed
the
flagd-web
branch
3 times, most recently
from
6049157 to
ff0bcc2
Compare
Member
Author
|
This is an updated and rebased version of: #112, with a few minor fixes and an update to 1.0 of the SDK |
Member
Author
|
Converted to draft - I'm going to do my own review tomorrow now that everything is up to date and working. |
toddbaert
commented
Nov 2, 2022
toddbaert
commented
Nov 2, 2022
beeme1mr
reviewed
Nov 2, 2022
tcarrio
reviewed
Nov 2, 2022
toddbaert
force-pushed
the
flagd-web
branch
5 times, most recently
from
fa5236b to
394a596
Compare
tcarrio
reviewed
Nov 4, 2022
toddbaert
commented
Nov 9, 2022
toddbaert
commented
Nov 9, 2022
skyerus
reviewed
Nov 9, 2022
Contributor
skyerus
left a comment
skyerus
left a comment
There was a problem hiding this comment.
Nice work, looking forward to seeing it in action!
beeme1mr
reviewed
Nov 10, 2022
toddbaert
force-pushed
the
flagd-web
branch
5 times, most recently
from
91be156 to
c18d511
Compare
beeme1mr
approved these changes
Nov 10, 2022
Member
beeme1mr
left a comment
beeme1mr
left a comment
There was a problem hiding this comment.
Looks good for an experimental release.
james-milligan
approved these changes
Nov 15, 2022
Signed-off-by: James-Milligan <[email protected]> Co-authored-by: Todd Baert <[email protected]>
Merged
This was referenced Jul 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This continues the work from: #112
Copying a snippet from the readme with an overview of features:
Reconnection
If the connection to the flagd instance fails, the provider will attempt to reconnect with an exponential back-off. The
maxDelayandmaxRetriescan be specified to customize reconnect behavior.Event streaming
The
FlagdWebProvidercan be configured to receive events for flag changes. Combined with the event API in the JS SDK, this allows for subscription to flag value changes in clients.Caching
The
FlagdWebProviderwill cache resolve flag values based on the associated flag-key and context. Values are cached in localstorage. A TTL for cached values can be specified. If event-streaming is enabled, the cache will be invalidated intelligently when flag configuration change events are received.