feat: Support mapping a client to a given provider.#388
Merged
justinabrahms merged 13 commits intomainfrom May 19, 2023
Merged
Conversation
justinabrahms
changed the title
justinabrahms
force-pushed
the
client-provider-mappings
branch
from
a1f948e to
a1bbf38
Compare
Codecov Report
@@ Coverage Diff @@
## main #388 +/- ##
============================================
+ Coverage 91.53% 93.20% +1.66%
- Complexity 213 220 +7
============================================
Files 23 23
Lines 496 500 +4
Branches 32 32
============================================
+ Hits 454 466 +12
+ Misses 24 17 -7
+ Partials 18 17 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
justinabrahms
force-pushed
the
client-provider-mappings
branch
from
e9a298f to
9932825
Compare
Member
If you think it's worth it, it could be something we mention in the glossary. |
Member
Author
|
Doc improvement: open-feature/spec#186 |
toddbaert
reviewed
May 4, 2023
toddbaert
reviewed
May 4, 2023
toddbaert
reviewed
May 4, 2023
toddbaert
reviewed
May 4, 2023
toddbaert
reviewed
May 4, 2023
toddbaert
reviewed
May 4, 2023
justinabrahms
force-pushed
the
client-provider-mappings
branch
from
7e5ec3d to
f2abe39
Compare
thiyagu06
reviewed
May 6, 2023
thiyagu06
reviewed
May 6, 2023
thiyagu06
reviewed
May 6, 2023
lopitz
suggested changes
May 6, 2023
Signed-off-by: Justin Abrahms <[email protected]>
Signed-off-by: Justin Abrahms <[email protected]>
Signed-off-by: Justin Abrahms <[email protected]>
Signed-off-by: Justin Abrahms <[email protected]>
Signed-off-by: Justin Abrahms <[email protected]>
Signed-off-by: Justin Abrahms <[email protected]>
Signed-off-by: Justin Abrahms <[email protected]>
… lock. Signed-off-by: Justin Abrahms <[email protected]>
Co-authored-by: Lars Opitz <[email protected]> Signed-off-by: Justin Abrahms <[email protected]>
There's no such thing as "API without a provider set" anymore. We now default to NoOpProvider in the API (not client). Signed-off-by: Justin Abrahms <[email protected]>
justinabrahms
force-pushed
the
client-provider-mappings
branch
from
777cb0b to
f5c60b5
Compare
Signed-off-by: Justin Abrahms <[email protected]>
toddbaert
approved these changes
May 8, 2023
| private EvaluationContext evaluationContext; | ||
| private List<Hook> apiHooks; | ||
| private final List<Hook> apiHooks; | ||
| private FeatureProvider defaultProvider = new NoOpProvider(); |
Contributor
There was a problem hiding this comment.
👍 for the noop default provider. This ensures null safety where possible.
Kavindu-Dodan
approved these changes
May 8, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Member
|
@justinabrahms @toddbaert any concerns about merging this? |
Member
Nope (but lets' not release until all this is done, IMO). |
thomaspoignant
approved these changes
May 19, 2023
This was referenced May 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
This adds support for mapping a client name onto a given provider, while still providing backwards compatibility to existing clients.
Related Issues
Refs open-feature/ofep#56
Fixes: #442
Follow-up Tasks
I still need to clean up documentation around this to note the difference between a "default provider" and a client-specific provider.
How to test
Not sure about testing, but I'd especially love eyes on the thread safety. I don't think ConcurrentHashMap is doing a lot of work here, given we have to use locks to support
getProviderForClientOrDefault. If you have a better way, I'm all ears.