Skip to content

fix: remove dep cycle with certreloader #1410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
toddbaert merged 1 commit into from
Sep 23, 2024
Merged

fix: remove dep cycle with certreloader #1410

toddbaert merged 1 commit into from
Sep 23, 2024

Conversation

@toddbaert
Copy link
Member

@toddbaert toddbaert commented Sep 23, 2024 •
edited
Loading

#1389 works well but caused a dependency cycle: flagd -> core -> flagd -> core.

I've moved the certreloader pkg to core with the existing telemetry stuff.

cc @kevinschoonover

@toddbaert toddbaert requested a review from a team September 23, 2024 12:32
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 23, 2024
@netlify
Copy link

netlify bot commented Sep 23, 2024 •
edited
Loading

✅ Deploy Preview for polite-licorice-3db33c canceled.

Name Link
🔨 Latest commit 5ee2549
🔍 Latest deploy log https://app.netlify.com/sites/polite-licorice-3db33c/deploys/66f15fdd79e91b00084b9880

@toddbaert toddbaert requested a review from thisthat September 23, 2024 12:33
@toddbaert toddbaert merged commit 5244f6f into main Sep 23, 2024
@toddbaert toddbaert deleted the fix/remove-dep-cycle branch September 23, 2024 13:24
@github-actions github-actions bot mentioned this pull request Sep 23, 2024
Merged
toddbaert pushed a commit that referenced this pull request Sep 23, 2024
@github-actions
chore: release main (#1395)
851b9da 
🤖 I have created a release *beep* *boop*
---


<details><summary>flagd: 0.11.3</summary>

##
[0.11.3](flagd/v0.11.2...flagd/v0.11.3)
(2024-09-23)


### 🐛 Bug Fixes

* **deps:** update kubernetes package and controller runtime, fix proto
lint ([#1290](#1290))
([94860d6](94860d6))
* **deps:** update module
buf.build/gen/go/open-feature/flagd/connectrpc/go to
v1.16.2-20240906125204-0a6a901b42e8.1
([#1399](#1399))
([18dd4e2](18dd4e2))
* **deps:** update module buf.build/gen/go/open-feature/flagd/grpc/go to
v1.5.1-20240906125204-0a6a901b42e8.1
([#1400](#1400))
([954d972](954d972))
* **deps:** update module connectrpc.com/connect to v1.17.0
([#1408](#1408))
([e7eb691](e7eb691))
* **deps:** update module github.com/open-feature/flagd/core to v0.10.2
([#1385](#1385))
([3b5a818](3b5a818))
* **deps:** update module github.com/prometheus/client_golang to v1.20.3
([#1384](#1384))
([8fd16b2](8fd16b2))
* **deps:** update module github.com/prometheus/client_golang to v1.20.4
([#1406](#1406))
([a0a6426](a0a6426))
* **deps:** update module github.com/rs/cors to v1.11.1
([#1392](#1392))
([8bd549e](8bd549e))
* **deps:** update module github.com/rs/xid to v1.6.0
([#1386](#1386))
([2317013](2317013))
* **deps:** update module golang.org/x/net to v0.29.0
([#1398](#1398))
([0721e02](0721e02))
* **deps:** update module google.golang.org/grpc to v1.66.0
([#1393](#1393))
([c96e9d7](c96e9d7))
* **deps:** update module google.golang.org/grpc to v1.66.1
([#1402](#1402))
([50c9cd3](50c9cd3))
* **deps:** update module google.golang.org/grpc to v1.66.2
([#1405](#1405))
([69ec28f](69ec28f))
* **deps:** update module google.golang.org/grpc to v1.67.0
([#1407](#1407))
([1ad6480](1ad6480))
* **deps:** update opentelemetry-go monorepo
([#1387](#1387))
([22aef5b](22aef5b))
* **deps:** update opentelemetry-go monorepo
([#1403](#1403))
([fc4cd3e](fc4cd3e))
* remove dep cycle with certreloader
([#1410](#1410))
([5244f6f](5244f6f))


### ✨ New Features

* add mTLS support to otel exporter
([#1389](#1389))
([8737f53](8737f53))
</details>

<details><summary>flagd-proxy: 0.6.6</summary>

##
[0.6.6](flagd-proxy/v0.6.5...flagd-proxy/v0.6.6)
(2024-09-23)


### 🐛 Bug Fixes

* **deps:** update kubernetes package and controller runtime, fix proto
lint ([#1290](#1290))
([94860d6](94860d6))
* **deps:** update module buf.build/gen/go/open-feature/flagd/grpc/go to
v1.5.1-20240906125204-0a6a901b42e8.1
([#1400](#1400))
([954d972](954d972))
* **deps:** update module github.com/open-feature/flagd/core to v0.10.2
([#1385](#1385))
([3b5a818](3b5a818))
* **deps:** update module github.com/prometheus/client_golang to v1.20.3
([#1384](#1384))
([8fd16b2](8fd16b2))
* **deps:** update module github.com/prometheus/client_golang to v1.20.4
([#1406](#1406))
([a0a6426](a0a6426))
* **deps:** update module golang.org/x/net to v0.29.0
([#1398](#1398))
([0721e02](0721e02))
* **deps:** update module google.golang.org/grpc to v1.66.0
([#1393](#1393))
([c96e9d7](c96e9d7))
* **deps:** update module google.golang.org/grpc to v1.66.1
([#1402](#1402))
([50c9cd3](50c9cd3))
* **deps:** update module google.golang.org/grpc to v1.66.2
([#1405](#1405))
([69ec28f](69ec28f))
* **deps:** update module google.golang.org/grpc to v1.67.0
([#1407](#1407))
([1ad6480](1ad6480))
* **deps:** update opentelemetry-go monorepo
([#1387](#1387))
([22aef5b](22aef5b))
* **deps:** update opentelemetry-go monorepo
([#1403](#1403))
([fc4cd3e](fc4cd3e))
* remove dep cycle with certreloader
([#1410](#1410))
([5244f6f](5244f6f))
</details>

<details><summary>core: 0.10.3</summary>

##
[0.10.3](core/v0.10.2...core/v0.10.3)
(2024-09-23)


### 🐛 Bug Fixes

* **deps:** update kubernetes package and controller runtime, fix proto
lint ([#1290](#1290))
([94860d6](94860d6))
* **deps:** update module buf.build/gen/go/open-feature/flagd/grpc/go to
v1.5.1-20240906125204-0a6a901b42e8.1
([#1400](#1400))
([954d972](954d972))
* **deps:** update module connectrpc.com/connect to v1.17.0
([#1408](#1408))
([e7eb691](e7eb691))
* **deps:** update module github.com/prometheus/client_golang to v1.20.3
([#1384](#1384))
([8fd16b2](8fd16b2))
* **deps:** update module github.com/prometheus/client_golang to v1.20.4
([#1406](#1406))
([a0a6426](a0a6426))
* **deps:** update module gocloud.dev to v0.39.0
([#1404](#1404))
([a3184d6](a3184d6))
* **deps:** update module golang.org/x/crypto to v0.27.0
([#1396](#1396))
([f9a7d10](f9a7d10))
* **deps:** update module golang.org/x/mod to v0.21.0
([#1397](#1397))
([1507e19](1507e19))
* **deps:** update module google.golang.org/grpc to v1.66.0
([#1393](#1393))
([c96e9d7](c96e9d7))
* **deps:** update module google.golang.org/grpc to v1.66.1
([#1402](#1402))
([50c9cd3](50c9cd3))
* **deps:** update module google.golang.org/grpc to v1.66.2
([#1405](#1405))
([69ec28f](69ec28f))
* **deps:** update module google.golang.org/grpc to v1.67.0
([#1407](#1407))
([1ad6480](1ad6480))
* **deps:** update opentelemetry-go monorepo
([#1387](#1387))
([22aef5b](22aef5b))
* **deps:** update opentelemetry-go monorepo
([#1403](#1403))
([fc4cd3e](fc4cd3e))
* remove dep cycle with certreloader
([#1410](#1410))
([5244f6f](5244f6f))


### ✨ New Features

* add mTLS support to otel exporter
([#1389](#1389))
([8737f53](8737f53))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@kevinschoonover
Copy link
Contributor

kevinschoonover commented Sep 23, 2024

@toddbaert, thanks for finding this. Do you know why the existing tests/pipelines didn't catch this? I would love to update them so this gets caught automatically this time.

Did I just not do a build with the most recent changes and can update the PR to do a test build?

@kevinschoonover kevinschoonover mentioned this pull request Sep 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beeme1mr beeme1mr beeme1mr approved these changes

@craigpastro craigpastro Awaiting requested review from craigpastro

@thisthat thisthat Awaiting requested review from thisthat

Assignees

No one assigned

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@toddbaert @kevinschoonover @beeme1mr