feat: Integrate hydro inflows from PEMMDB#77
Merged
daniel-rdt merged 28 commits intomasterfrom Sep 1, 2025
Merged
Conversation
… include rule for hydro inflows data
10 tasks
Member
Author
tgilon
approved these changes
Aug 14, 2025
Member
tgilon
left a comment
There was a problem hiding this comment.
Thank you @daniel-rdt for this PR! I mainly have style comments. Once you have gone through them, feel free to merge the PR.
Side notes:
- In the PR description, the
retrieverule is missing from the graph. - Could you also add a note of the results of #96 to the PR description? It's not explicit atm.
Co-authored-by: Thomas Gilon <[email protected]>
12 tasks
33 tasks
tgilon
pushed a commit
that referenced
this pull request
Nov 20, 2025
* Add pixi install and dev instructions to README * Add CI test config updates * Add manifest sharing instructions * Remove manifest path statement in favour of note.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #74.
Changes proposed in this Pull Request
This PR integrates the PEMMDB hydro inflow data for the 2024 TYNDP into the workflow introducing a data pipeline to deal with the raw data and build hydro profiles that can be used for different hydro technologies.
Available hydro technologies are:
For more information and the differentiation between the different technologies, please refer to ENTSO-E's 'Hydropower modelling methodology' (2019)
Note: Similar to #71, this PR serves to facilitate a sub-workflow for creation of the hydro inflow profiles but does not yet attach them to any technologies yet. This will be added in a follow up PR.
Additionally required steps are:
The supplied available inflow profiles were reviewed for consistency with available PEMMDB capacities in #96.
The review showed that no necessary data is missing entirely while there are some inflow profiles with zero-values which warrant further clarification whether this is indeed correct. The issue is reported in the Open-TYNDP transparency report.
Tasks
retrieve_tyndp_hydro_inflowsruleWorkflow
The introduced workflow data pipeline for the PEMMDB hydro inflow data includes the following steps:
retrieve_tyndp_hydro_inflows: Rule to retrieve the TYNDP 2024 hydro inflow data and save in thetyndp_2024_bundledirectoryclean_tyndp_hydro_inflows: Rule to clean the TYNDP hydro inflows. This rule depends on two wildcards:planning_horizonwildcard which can be one of the years (2030, 2040 and 2050) for which hydro inflow data is available.techwildcard which specifies the hydroelectric technology ("Run of River", "Pondage", "Reservoir", "PS Open", "PS Closed") for which the inflow profile needs to be extracted. This allow parallelization of the processing of the different technologies.build_tyndp_hydro_profileThe rule provides a
resources/profile_hydro_tyndp.ncfile with the following structure:The following graph illustrates the workflow from the cleaning step to
prepare_sector_networkforconfig/test/config.tyndp.yaml:Open issues
The review (#96) showed that no necessary data is missing entirely while there are some inflow profiles with zero-values which warrant further clarification whether this is indeed correct.
The following hydro inflow profiles show zero-values while having specified turbine capacities:
2030
Run of River
ITS1Reservoir
SI00PS Open
NON1FR002040
Run of River
ITS1Reservoir
SI00PS Open
NON1FR00MK002050
Run of River
ITS1Reservoir
SI00PS Open
NON1FR00MK00Notes
Checklist
envs/environment.yaml.config/config.default.yaml.doc/configtables/*.csv.config/test/*.yaml.doc/data_sources.rst.doc/release_notes.rstis added.