Skip to content

feat: Integrate hydro inflows from PEMMDB#77

Merged
daniel-rdt merged 28 commits intomasterfrom
feat/74-hydro-inflows
Sep 1, 2025
Merged

feat: Integrate hydro inflows from PEMMDB#77
daniel-rdt merged 28 commits intomasterfrom
feat/74-hydro-inflows

Conversation

@daniel-rdt
Copy link
Copy Markdown
Member

@daniel-rdt daniel-rdt commented Jul 21, 2025

Closes #74.

Changes proposed in this Pull Request

This PR integrates the PEMMDB hydro inflow data for the 2024 TYNDP into the workflow introducing a data pipeline to deal with the raw data and build hydro profiles that can be used for different hydro technologies.

Available hydro technologies are:

  • PS Closed
  • PS Open
  • Pondage
  • Reservoir
  • Run of River

For more information and the differentiation between the different technologies, please refer to ENTSO-E's 'Hydropower modelling methodology' (2019)

Note: Similar to #71, this PR serves to facilitate a sub-workflow for creation of the hydro inflow profiles but does not yet attach them to any technologies yet. This will be added in a follow up PR.

Additionally required steps are:

The supplied available inflow profiles were reviewed for consistency with available PEMMDB capacities in #96.
The review showed that no necessary data is missing entirely while there are some inflow profiles with zero-values which warrant further clarification whether this is indeed correct. The issue is reported in the Open-TYNDP transparency report.

Tasks

  • Introduce data pipeline for cleaning hydro inflow data
  • Add retrieve rule for Hydro Inflows data
  • Merge master
  • Build hydro profiles
  • Update the documentation of the PR
  • Add release note
  • fix CI
  • Improve documentation of retrieve_tyndp_hydro_inflows rule
  • Validate data per year and against available capacities (see feat: share testing notebook for hydro inflow data #96)

Workflow

The introduced workflow data pipeline for the PEMMDB hydro inflow data includes the following steps:

  • (new) retrieve_tyndp_hydro_inflows: Rule to retrieve the TYNDP 2024 hydro inflow data and save in the tyndp_2024_bundle directory
  • (new) clean_tyndp_hydro_inflows: Rule to clean the TYNDP hydro inflows. This rule depends on two wildcards:
    • The planning_horizon wildcard which can be one of the years (2030, 2040 and 2050) for which hydro inflow data is available.
    • The tech wildcard which specifies the hydroelectric technology ("Run of River", "Pondage", "Reservoir", "PS Open", "PS Closed") for which the inflow profile needs to be extracted. This allow parallelization of the processing of the different technologies.
  • (new) build_tyndp_hydro_profile
    • The rule provides a resources/profile_hydro_tyndp.nc file with the following structure:

      Field Dimensions Description
      inflow bus, time, year, hydro_tech Inflow to the state of charge (in MW), e.g. due to river inflow in hydro reservoir.

The following graph illustrates the workflow from the cleaning step to prepare_sector_network for config/test/config.tyndp.yaml:

image

Open issues

The review (#96) showed that no necessary data is missing entirely while there are some inflow profiles with zero-values which warrant further clarification whether this is indeed correct.

The following hydro inflow profiles show zero-values while having specified turbine capacities:

2030

Run of River

  • ITS1

Reservoir

  • SI00

PS Open

  • NON1
  • FR00

2040

Run of River

  • ITS1

Reservoir

  • SI00

PS Open

  • NON1
  • FR00
  • MK00

2050

Run of River

  • ITS1

Reservoir

  • SI00

PS Open

  • NON1
  • FR00
  • MK00

Notes

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Changes in configuration options are added in config/test/*.yaml.
  • OET license identifier is added to all edited or newly created code files.
  • Sources of newly added data are documented in doc/data_sources.rst.
  • A release note doc/release_notes.rst is added.

@daniel-rdt daniel-rdt self-assigned this Jul 21, 2025
@tgilon tgilon added this to the Release v0.3 milestone Jul 22, 2025
@tgilon tgilon added the major feature Major feature for the Open TYNDP. label Jul 22, 2025
@daniel-rdt daniel-rdt marked this pull request as ready for review August 1, 2025 15:56
@daniel-rdt daniel-rdt requested a review from tgilon August 1, 2025 15:56
@daniel-rdt
Copy link
Copy Markdown
Member Author

@tgilon The PR is ready for your review. You can find the review notebook for consistency here.

Copy link
Copy Markdown
Member

@tgilon tgilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @daniel-rdt for this PR! I mainly have style comments. Once you have gone through them, feel free to merge the PR.

Side notes:

  • In the PR description, the retrieve rule is missing from the graph.
  • Could you also add a note of the results of #96 to the PR description? It's not explicit atm.

Comment thread doc/release_notes.rst Outdated
Comment thread doc/retrieve.rst
Comment thread config/config.default.yaml Outdated
Comment thread doc/configtables/electricity.csv Outdated
Comment thread doc/configtables/electricity.csv Outdated
Comment thread scripts/prepare_sector_network.py
Comment thread scripts/build_tyndp_hydro_profile.py Outdated
Comment thread scripts/build_tyndp_hydro_profile.py Outdated
Comment thread scripts/build_tyndp_hydro_profile.py Outdated
Comment thread scripts/retrieve_additional_tyndp_data.py Outdated
@daniel-rdt daniel-rdt requested a review from coroa August 18, 2025 14:05
@daniel-rdt daniel-rdt merged commit c2d56c8 into master Sep 1, 2025
5 checks passed
@daniel-rdt daniel-rdt deleted the feat/74-hydro-inflows branch September 1, 2025 16:02
tgilon pushed a commit that referenced this pull request Nov 20, 2025
* Add pixi install and dev instructions to README

* Add CI test config updates

* Add manifest sharing instructions

* Remove manifest path statement in favour of note.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

major feature Major feature for the Open TYNDP.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integration of hydro inflows from PEMMDB (at least 1995, 2008 and 2009)

2 participants