feat: add pypsa explorer to workflow#443
Conversation
lisazeyen
left a comment
There was a problem hiding this comment.
Great @daniel-rdt I have opened the Explorer with the test config and everything was working smoothly. I am just not sure that the current implementation is working with Windows, there is on Linux/Unix specific command which maybe is going to cause troubles. Can you find a way around? Sorry, I didn't have the the time to make any concrete suggestions on how to change it.
Thanks @lisazeyen good catch! I've consulted with Claude and docs and it seems that using an alternate argument on Windows will solve the problem. Since I can't test this however, maybe @cdgaete you could try this out on your Windows machine? Note that you will have to set |
lisazeyen
left a comment
There was a problem hiding this comment.
LGTM but probably still good if somebody runs a test on windows. You could also try to run it on one of the VM for Windows from OET.
Thanks! Definitely would like to test it on a Windows machine first. I am not quite sure it will be possible to test the automatic pop open of the browser tab on the VM though. |
|
@daniel-rdt, I test it on my Windows machine ... |
|
@daniel-rdt No browser popup observered using WIndows (WSL). |
Thanks @gincrement for testing this. I unfortunately do not have time before the next release to address the issue properly to make the pop out work on Windows. I will add a logger info for now for users to access the explorer in case it does not pop open automatically. We can improve this with a follow up. I opened an issue #460 to follow up on this. |
…ge for Windows users
|
@gincrement Added the message. Would be great if you could test this a final time before maybe @lisazeyen can merge this on Monday to include in our release v0.5. Thanks both! :) |
|
Shows the message as expected. Good for now!! |
Closes #266.
Changes proposed in this Pull Request
This PR proposes to add the PyPSA explorer to the workflow.
The PyPSA-Explorer will be launched on the first available port between 8050 and 8100 and a browser tab with the launched explorer will automatically pop open.
The explorer will be launched with the result networks of a scenario. This means if three scenarios are executed in parallel three different explorers are launched on different ports.
Tasks
Workflow
Two new rules are added to the workflow and new configuration switch is added that controls the launch of the explorer.
launch_explorer: Switch to launch the explorer, per default this is False and also for the test configuration. It is True forconfig/config.tyndp.yamllaunch_explorerthat is added to the workflow under SB: Will launch the PyPSA-Explorer with all planning horizon networks.close_explorersthat is also added under SB: Will close all open instances of the PyPSA-Explorer freeing up ports again.Open issues
Notes
Checklist
pixi.toml(usingpixi add <dependency-name>).config/config.default.yaml.config/test/*.yaml.doc/*.rstfiles.doc/release_notes.rstis added.READMEanddoc/index.rst.