Skip to content

refactor: tyndp H2 reference grid in line with using planning_horizon for filtering the tyndp year#37

Merged
daniel-rdt merged 3 commits intomasterfrom
feature/planning-horizon-wildcard-for-h2-grid
May 9, 2025
Merged

refactor: tyndp H2 reference grid in line with using planning_horizon for filtering the tyndp year#37
daniel-rdt merged 3 commits intomasterfrom
feature/planning-horizon-wildcard-for-h2-grid

Conversation

@daniel-rdt
Copy link
Copy Markdown
Member

Changes proposed in this Pull Request

This PR brings the processing of the TYNDP reference grid in line with using the planning_horizon wildcard for the filtering of the TYNDP year. This is necessary for pathway optimization with different input reference grids for different planning years.

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Sources of newly added data are documented in doc/data_sources.rst.
  • A release note doc/release_notes.rst is added.

@daniel-rdt daniel-rdt requested a review from tgilon May 7, 2025 11:52
* Update environment.yaml

* Update test.yaml

* Updatedate test.yaml

* Upupdatedate test.yaml

* dateUp test.yaml

* fix: remove cache for inhouse

* Update test.yaml

---------

Co-authored-by: Lukas Trippe <[email protected]>
@daniel-rdt daniel-rdt changed the title refactor: bring tyndp reference grid processing in line with using planning_horizon for filtering the tyndp year refactor: tyndp H2 reference grid in line with using planning_horizon for filtering the tyndp year May 8, 2025
Copy link
Copy Markdown
Member

@tgilon tgilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need to consider having a single scenario config through the whole the configuration file.

@daniel-rdt
Copy link
Copy Markdown
Member Author

daniel-rdt commented May 9, 2025

We probably need to consider having a single scenario config through the whole the configuration file.

Yes, I also thought about this. We probably want to have a section on TYNDP somewhere central. At the same time, having the individual options allows for more fine tuning. But being able to select two different TYNDP scenarios for different elements does not make sense indeed

@tgilon Would you say, it makes sense to introduce this here already?

@tgilon
Copy link
Copy Markdown
Member

tgilon commented May 9, 2025

@tgilon Would you say, it makes sense to introduce this here already?

I suggest to do it when the two PRs are merged. It'll be easier. I raised the point in an issue: #39.

@daniel-rdt
Copy link
Copy Markdown
Member Author

@tgilon Would you say, it makes sense to introduce this here already?

I suggest to do it when the two PRs are merged. It'll be easier. I raised the point in an issue: #39.

LGTM then 💪

@daniel-rdt daniel-rdt merged commit 502248c into master May 9, 2025
9 checks passed
@daniel-rdt daniel-rdt deleted the feature/planning-horizon-wildcard-for-h2-grid branch May 9, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants