Conversation
This reverts commit 6d2bf9c.
* fix: intermediate fix to make solar_thermal_total not an optional input to be able to use segmentation option * fix: intermediate fix to use 168H instead of 52SEG as long as segmentation option is compromised * Revert "fix: intermediate fix to make solar_thermal_total not an optional input to be able to use segmentation option" This reverts commit afb9617. * doc: add a note for SEG option not being supported with the current configuration
tgilon
left a comment
tgilon
left a comment
There was a problem hiding this comment.
Thank you @daniel-rdt for this PR! I have to say that it's really good first round. You'll find my comments below. The only general remark is that I still find it confusing that both capacities and inflows are added in a separate function. However, I know this will be addressed in #286.
Co-authored-by: Thomas Gilon <[email protected]>
…export of pypsa network
|
Thanks @tgilon. for the comments and thorough review. I addressed all of the comments now. We only have two last open comments where I need to know if that works for you. Otherwise, regarding the structure of splitting adding the components and the caps/inflows separately, I do agree that it is a bit confusing at times. This was especially true for hydro as, capacities and inflows are linked, so it only makes sense to add both in the same place. This on the other hand means, that in a hypothetical greenfield approach, the previously added "empty" components are not complete even if they are extendable because they are still missing the inflows. For our purposes, this limitation should be fine however, imo. As you correctly point out, this logic will hopefully be improved with #286. |
tgilon
left a comment
tgilon
left a comment
There was a problem hiding this comment.
Thank you @daniel-rdt for the revisions, looks good to go!
# Conflicts: # doc/release_notes.rst # envs/default_linux-64.pin.txt # envs/default_osx-64.pin.txt # envs/default_osx-arm64.pin.txt # envs/default_win-64.pin.txt # pixi.lock # scripts/add_brownfield.py
|
@tgilon Master has been merged. Not too many merge conflicts, mainly in
I did not find an instance that would be directly affected by the data layer changes, as the retrieve and processing was already in master. Would be great if you could have a final look mainly on the changes in the rules if you agree that they are consistent before we merge (and once CI hopefully passes 🤞) |
tgilon
left a comment
tgilon
left a comment
There was a problem hiding this comment.
Everything looks good to me! Thank you for the final stretch, ready to be merged after the release
2 participants
Closes #152.
Changes proposed in this Pull Request
This PR proposes to add TYNDP hydro technologies to the model along with associated PEMMDB capacities and inflows.
The associated technologies will be modelled as follows:
This PR does not yet include the modelling of additional constraints such as generation / pumping power constraints, generated / pumped energy constraints, or reservoir level constraints. They will be addressed by a follow up PR associated to issue #226.
Tasks
-> will be addressed by [PARENT] Calibration of parameters: cost assumptions, losses, emission factors and efficiencies #69
-> will be addressed by [PARENT] Remove all non-extendable assets without capacity from the model before solving #209
Workflow
As for the implementation of TYNDP conventional thermal technologies and capacities, the addition will be separated into two subsequent steps in
prepare_sector_network:TYNDP Hydro technologies will replace the default Hydro technologies. Therefore,
hydrowill be removed from the list ofrenewable_carriersand instead the separate TYNDP hydro techs are included in the list oftyndp_renewable_carriers:The following changes are made in
prepare_sector_network,process_costsandadd_brownfield:add_hydro_tyndp: New function that attaches TYNDP hydro technologies to the network without any associated capacities and hydro profiles_add_hydro_capacities: New function inside ofadd_existing_pemmdb_capacitiesthat adds hydro capacities and profiles to a given PyPSA network for the associated technologiesadd_brownfieldthat drop conventional cumulative capacities from the previous planning horizon to also drop cumulative previous hydro technologies as hydro is also not modelled as an expandable carrier.Open issues
Questions:
Notes
The following assumptions are taken:
After adding TYNDP hydro technologies and PEMMDB capacities to the model, the capacity benchmarking looks as follows:
2030
2040
Checklist
config/config.default.yaml.doc/configtables/*.csv.config/test/*.yaml.doc/release_notes.rstis added.READMEanddoc/index.rst.