[Fix] In cascaded evaluation, the return value is None when the rule evaluation is 100% correct.#2211
Merged
tonysy merged 2 commits intoopen-compass:mainfrom Sep 9, 2025
Merged
Conversation
…evaluation is 100% correct.
Collaborator
|
Thanks for your contribution, we will review this PR. |
Collaborator
|
Thanks for your contribution. @jibuzixin |
zyc140345
pushed a commit
to zyc140345/opencompass
that referenced
this pull request
Oct 23, 2025
…evaluation is 100% correct. (open-compass#2211) * [Fix] In cascaded evaluation, the return value is None when the rule evaluation is 100% correct. * Update cascade_evaluator.py --------- Co-authored-by: Myhs_phz <[email protected]>
iamkaia
pushed a commit
to iamkaia/opencompass
that referenced
this pull request
Feb 4, 2026
…evaluation is 100% correct. (open-compass#2211) * [Fix] In cascaded evaluation, the return value is None when the rule evaluation is 100% correct. * Update cascade_evaluator.py --------- Co-authored-by: Myhs_phz <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Fix] In cascaded evaluation, the return value is None when the rule evaluation is 100% correct.
问题描述
在使用级联评测的时候，如果规则评测的correct都是正确的（也就是100准确率），就进入不了cascade_evaluator.py文件183行的if语句，导致最后score函数返回的是None。
然后在BaseEvaluator类evaluate方法中145行results.pop('details', None)就会报错，results为空。
解决办法
多加一个else语句，保证格式统一，然后必定返回一个results。