Skip to content

[fix] output sequence under the multiple samples#1707

Merged
MaiziXiao merged 15 commits intoopen-compass:mainfrom
cuauty:sequence_under_multiple_samples
Nov 26, 2024
Merged

[fix] output sequence under the multiple samples#1707
MaiziXiao merged 15 commits intoopen-compass:mainfrom
cuauty:sequence_under_multiple_samples

Conversation

@cuauty
Copy link
Copy Markdown
Contributor

@cuauty cuauty commented Nov 20, 2024

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

This PR makes the same sequence with input sample under the multiple samples.

Modification

Please briefly describe what modification is made in this PR.

construct the result list in advance then set the result of each sample in-place.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

Comment thread opencompass/models/bailing_api_oc.py Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass 的话 results数量会和问题数量不一致

Copy link
Copy Markdown
Contributor Author

@cuauty cuauty Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个修改使用的in-place方式,预先用空值把results和输入的数量对齐了。这个地方改为记录日志供分析使用。

@cuauty cuauty force-pushed the sequence_under_multiple_samples branch from ee20130 to a54a21f Compare November 22, 2024 08:48
Copy link
Copy Markdown
Contributor

@MaiziXiao MaiziXiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaiziXiao MaiziXiao merged commit bcb707d into open-compass:main Nov 26, 2024
stephen-nju pushed a commit to stephen-nju/opencompass that referenced this pull request May 14, 2025
* [fix] sequence under the multiple samples

* resolve the lint problems

* change the parameter name

* add another error code for retry

* output the log for invalid response

* format correction

* update

* update

* update

* update

* add two model python files

* update the default parameter

* use random for delay

* update the api example of bailing

* remove the unnecessary parameter
zyc140345 pushed a commit to zyc140345/opencompass that referenced this pull request Oct 23, 2025
* [fix] sequence under the multiple samples

* resolve the lint problems

* change the parameter name

* add another error code for retry

* output the log for invalid response

* format correction

* update

* update

* update

* update

* add two model python files

* update the default parameter

* use random for delay

* update the api example of bailing

* remove the unnecessary parameter
iamkaia pushed a commit to iamkaia/opencompass that referenced this pull request Feb 4, 2026
* [fix] sequence under the multiple samples

* resolve the lint problems

* change the parameter name

* add another error code for retry

* output the log for invalid response

* format correction

* update

* update

* update

* update

* add two model python files

* update the default parameter

* use random for delay

* update the api example of bailing

* remove the unnecessary parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants