Skip to content

fix(review): separate future follow-ups from intake blockers - #3982

Merged
CocoSgt merged 1 commit into
open-city-ai:mainfrom
dvd233:codex/review-action-semantics-20260824
Aug 24, 2026
Merged

CocoSgt merged 1 commit into
open-city-ai:mainfrom
dvd233:codex/review-action-semantics-20260824

Conversation

@dvd233

@dvd233 dvd233 commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • bump the advisory review contract to 0.2.0 and add structured conditional_followups with required blocking_now=false, trigger, and owner
  • reserve required_next_actions_zh / per-dimension repairs for current participant-controlled blockers, while rendering future-stage conditions in a separate non-blocking section
  • make the trusted worker supply the current canonical schema to old PR worktrees and invalidate cached reviews from earlier schema versions
  • keep the queue fail-closed for malformed conditional records and for every current participant repair

Root cause and safety boundary

The flat required_next_actions_zh list had to carry both current repairs and future-stage conditions. The normalizer and queue therefore converted any condition into request-changes, even when the review itself called it non-blocking. This patch adds an explicit machine-readable distinction instead of inferring ownership or timing from keywords.

A current unsupported claim is still a blocker: the participant must correct the claim now. Only work whose stated trigger has not occurred belongs in conditional_followups.

The authoritative PR comment now renders current blockers and conditional follow-ups separately. This does not duplicate #3743, which remains the separate accept-path delivery fix for posting the full authoritative comment.

Verification

  • python -m unittest discover -s tests -p 'test_*review*.py' -v — 89/89 passed
  • focused advisory / queue / prompt modules — 43/43 passed after the final template update
  • py_compile for the three changed review scripts — passed
  • git diff --check and schema JSON parse — passed
  • worker-shape dry-run against PR feat: expose synthetic capacity gates in review carriers #3821 exact head 452b367ff3c19fc5079a38fc60999c86fd084faa using the trusted 0.2.0 schema — succeeded; reviewed package hash remained c8eca57bd34497af50bc53db1d625d1a6299d1cef334906024d3311816fe54eb

A broader sparse-worktree run passed 287/289 non-symlink/non-gallery tests; the two remaining failures were unrelated existing/sparse-fixture checks (cover separator text and generated gallery state without all submissions materialized).

Rollout note

This code intentionally does not mutate existing PR reviews or labels. Existing changes-requested PRs need a maintainer requeue or manual intake decision after this lands; the schema-version check then prevents reuse of their old cached advisory result.

Addresses #3980.

The flat required-action list made future-stage conditions block intake. Add structured non-blocking follow-ups, trusted-schema cache invalidation, and fail-closed queue validation.
@github-actions

Copy link
Copy Markdown
Contributor

Haidian Submission Validation

Submission validation

Result: PASS
Changed files: 10
Proposal files: 0
Changelog files: 0

Warnings:

  • non-submission code/docs/test PR; participant package validation was not applicable

This CI check is deterministic. It does not call AI models and does not make content-quality judgments.

@CocoSgt CocoSgt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exact head d2b0a8b4fcba412e21ca3b0d3e4901fa28422248 reproduces and fixes the fail-closed/fail-close ambiguity without weakening current gates: current participant-controlled repairs remain blocking, while explicit future-triggered items require blocking_now=false, a nonempty trigger, and a bounded owner enum. Schema-invalid or ambiguous items still fail closed; the worker invalidates legacy cached reviews by schema version and uses the trusted current-main schema. Independent Python 3.9.6 verification passed 56/56 related review/encoding tests, three-script py_compile, schema JSON parsing, and git diff --check; required exact-head CI is SUCCESS. This aligns the existing documented repository-intake boundary and does not alter the 60-point floor, mandatory rejection, four local gates, publication semantics, participant path scope, or exact-head checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants