Fix CarouselAutoAdvanceEffect#2748
Merged
StageGuard merged 10 commits intoopen-ani:mainfrom Jan 4, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR attempts to fix issue #2642, which reports stuttering behavior in the homepage carousel when auto-advancing to the last slide on Android devices.
Key Changes
- Modified the target page calculation logic to check for floating-point offset drift and reset to page 0 when drift exceeds 0.1
- Replaced the configurable animation spec with a hardcoded tween animation (300ms, LinearEasing)
- Added a synchronous scrollToItem call after the animated scroll to ensure position precision
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...shared/ui-foundation/src/commonMain/kotlin/ui/foundation/layout/CarouselAutoAdvanceEffect.kt
Outdated
Show resolved
Hide resolved
...shared/ui-foundation/src/commonMain/kotlin/ui/foundation/layout/CarouselAutoAdvanceEffect.kt
Outdated
Show resolved
Hide resolved
...shared/ui-foundation/src/commonMain/kotlin/ui/foundation/layout/CarouselAutoAdvanceEffect.kt
Outdated
Show resolved
Hide resolved
...shared/ui-foundation/src/commonMain/kotlin/ui/foundation/layout/CarouselAutoAdvanceEffect.kt
Outdated
Show resolved
Hide resolved
...shared/ui-foundation/src/commonMain/kotlin/ui/foundation/layout/CarouselAutoAdvanceEffect.kt
Outdated
Show resolved
Hide resolved
…ayout/CarouselAutoAdvanceEffect.kt Co-authored-by: Copilot <[email protected]>
…ayout/CarouselAutoAdvanceEffect.kt Co-authored-by: Copilot <[email protected]>
# Conflicts: # app/shared/ui-foundation/src/commonMain/kotlin/ui/foundation/layout/CarouselAutoAdvanceEffect.kt
StageGuard
reviewed
Jan 2, 2026
app/shared/ui-foundation/src/commonMain/kotlin/ui/foundation/animation/AniMotionScheme.kt
Outdated
Show resolved
Hide resolved
Kesoft
commented
Jan 3, 2026
app/shared/ui-foundation/src/commonMain/kotlin/ui/foundation/animation/AniMotionScheme.kt
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复首页轮播图抽搐
fix issue #2642