fix(ui): default widget will be correctly highlighted when entering the settings page#2653
Merged
Him188 merged 1 commit intoopen-ani:mainfrom Nov 6, 2025
sukurajima-mai:fix/settings-default-tab
Merged
fix(ui): default widget will be correctly highlighted when entering the settings page#2653Him188 merged 1 commit intoopen-ani:mainfrom sukurajima-mai:fix/settings-default-tab
Him188 merged 1 commit intoopen-ani:mainfrom
sukurajima-mai:fix/settings-default-tab
Conversation
Him188
approved these changes
Nov 4, 2025
Contributor
Author
|
macOS的build怎么自动取消了👀 |
Member
|
这个 pr 有严重的 bug，更改主题设置后会重置页面状态。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Added a flag to ensure the "Appearance" settings tab is automatically selected and highlighted in wide-screen (list-detail) layout when entering the settings screen without a specified initial tab.
Why
Previously, in wide-screen mode, the settings screen would display the first tab’s content by default but failed to visually highlight it in the navigation rail, leading to a mismatch between the displayed content and the selected UI state. This occurred because the initial selection logic didn’t account for layout context when no initialTab was provided. Users saw the Appearance (or first) tab content but with no navigation item highlighted, causing confusion.
Where
SettingsScreen.kt: Introduced early calculation of layoutParameters and updated the lastSelectedTab initialization logic to default to SettingsTab.APPEARANCE in list-detail (non-single-pane) layouts when initialTab is null.
Close
#2652