This repository was archived by the owner on Jan 16, 2026. It is now read-only.
Conversation
theochap
requested review from
BioMark3r,
einar-oplabs,
emhane and
op-will
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request enhances the defensive validation of deposit contract fields by improving the parsing logic to ensure proper Solidity ABI encoding. While deposit contracts are trusted by default, this change applies more rigorous validation to catch malformed data early.
- Changes U64 parsing to U256 for offset and length fields to match full 32-byte ABI encoding
- Adds new error variants with more descriptive messages for various validation failures
- Implements additional validation for opaque data padding to ensure all padding bytes are zeros
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
op-will
reviewed
Nov 24, 2025
…tract fields are well encoded
theochap
force-pushed
the
theo/fix-proofs-contract
branch
from
ee97e15 to
ce1d52e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. |
op-will
approved these changes
Nov 25, 2025
theochap
force-pushed
the
theo/fix-proofs-contract
branch
from
fd94ea9 to
322fb64
Compare
theochap
added a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
…tract fields are well encoded (op-rs/kona#3078) ## Description Currently the protocol assumes that all the deposit contract fields are encoded using solidity's compiler. Those contracts are trusted by default, but we may want to apply a more defensive programming approach and ensure that all the fields are well formatted anyways.
theochap
added a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 14, 2026
…tract fields are well encoded (op-rs/kona#3078) ## Description Currently the protocol assumes that all the deposit contract fields are encoded using solidity's compiler. Those contracts are trusted by default, but we may want to apply a more defensive programming approach and ensure that all the fields are well formatted anyways.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently the protocol assumes that all the deposit contract fields are encoded using solidity's compiler. Those contracts are trusted by default, but we may want to apply a more defensive programming approach and ensure that all the fields are well formatted anyways.