fix(node/test): lower finalization threshold for TestSyncFinalized#3061
fix(node/test): lower finalization threshold for TestSyncFinalized#3061
Conversation
theochap
requested review from
BioMark3r,
einar-oplabs,
emhane and
op-will
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a flaky test by reducing the finalization threshold requirement from at least 2 blocks to at least 1 block within a 4-minute window. This makes the test more reliable while still validating that finalized blocks are being received and synced correctly across nodes.
Key Changes:
- Updated finalization threshold from 2 to 1 block in the assertion
- Changed
require.Greatertorequire.GreaterOrEqualto properly check for at least 1 block - Updated the comment to reflect the new threshold
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. |
op-will
left a comment
op-will
left a comment
There was a problem hiding this comment.
Looks good to me 👍
This reduces the potential number of blocks being checked to a minimum of 1, but it doesn't change the sync requirements of each block, so it should still catch errors.
Co-authored-by: Copilot <[email protected]>
…p-rs/kona#3061) ## Description The finalization test was flaking because we didn't get enough new blocks finalized. This test ensures we are receiving at least one finalized block within 4 mins. --------- Co-authored-by: Copilot <[email protected]>
…p-rs/kona#3061) ## Description The finalization test was flaking because we didn't get enough new blocks finalized. This test ensures we are receiving at least one finalized block within 4 mins. --------- Co-authored-by: Copilot <[email protected]>
Description
The finalization test was flaking because we didn't get enough new blocks finalized. This test ensures we are receiving at least one finalized block within 4 mins.