This repository was archived by the owner on Jan 16, 2026. It is now read-only.
Remove unnecessary clone of chain_dbs_map in init_l1_watcher#2990
Merged
theochap merged 2 commits intoop-rs:mainfrom Dec 4, 2025
Merged
Remove unnecessary clone of chain_dbs_map in init_l1_watcher#2990theochap merged 2 commits intoop-rs:mainfrom
theochap merged 2 commits intoop-rs:mainfrom
Conversation
Contributor
sashass1315
commented
Oct 28, 2025
sashass1315
commented
- Eliminated chain_dbs_map.clone() before constructing ReorgHandler in Service::init_l1_watcher().
- The map is created for the spawned task and not used elsewhere, so it can be moved safely.
- This reduces allocations and minor overhead without changing behavior.
sashass1315
requested review from
BioMark3r,
emhane and
theochap
as code owners
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. |
Contributor
|
This pull request has been automatically marked as stale because it has been inactive for 3 weeks. |
theochap
approved these changes
Dec 3, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
theochap
added a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
…ona#2990) - Eliminated chain_dbs_map.clone() before constructing ReorgHandler in Service::init_l1_watcher(). - The map is created for the spawned task and not used elsewhere, so it can be moved safely. - This reduces allocations and minor overhead without changing behavior. Co-authored-by: theo <[email protected]>
theochap
added a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 14, 2026
…ona#2990) - Eliminated chain_dbs_map.clone() before constructing ReorgHandler in Service::init_l1_watcher(). - The map is created for the spawned task and not used elsewhere, so it can be moved safely. - This reduces allocations and minor overhead without changing behavior. Co-authored-by: theo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.