This repository was archived by the owner on Jan 16, 2026. It is now read-only.
docs(beacon): clarify new_http docstring to reflect String input inst…#2969
Merged
theochap merged 2 commits intoop-rs:mainfrom Dec 8, 2025
Merged
docs(beacon): clarify new_http docstring to reflect String input inst…#2969theochap merged 2 commits intoop-rs:mainfrom
theochap merged 2 commits intoop-rs:mainfrom
Conversation
gap-editor
requested review from
BioMark3r,
emhane and
theochap
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. |
Contributor
|
This pull request has been automatically marked as stale because it has been inactive for 3 weeks. |
Contributor
Author
|
dont forget to merge this PR! thanks! |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
theochap
approved these changes
Dec 8, 2025
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
op-rs/kona#2969) Pull Request description: This PR updates the documentation for `OnlineBeaconClient::new_http` to accurately describe its parameter type. Previously, the doc comment mentioned `reqwest::Url`, but the function actually takes a plain `String` as the base URL. Co-authored-by: einar-oplabs <[email protected]>
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 14, 2026
op-rs/kona#2969) Pull Request description: This PR updates the documentation for `OnlineBeaconClient::new_http` to accurately describe its parameter type. Previously, the doc comment mentioned `reqwest::Url`, but the function actually takes a plain `String` as the base URL. Co-authored-by: einar-oplabs <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request description:
This PR updates the documentation for
OnlineBeaconClient::new_httpto accurately describe its parameter type.Previously, the doc comment mentioned
reqwest::Url, but the function actually takes a plainStringas the base URL.