feat: add factory for TLS proxying with uTLS (v2)#19
Merged
bassosimone merged 1 commit intomainfrom Jan 4, 2022
Merged
Conversation
This commit adds an experimental factory for create proxying TLS connections using uTLS rather than crypto/tls. A user has requested this functionality. For now, I'd like to avoid advertising it until I get confirmation that this interface is okay for the user who requested it. When it's confirmed it's okay, I'll change the README. The v1 implementation of this functionality was in commit d6f7e24. Yet, it turns out the TLSClientFactory ended up having the wrong return type (`*tls.Conn`). This return type is incorrect; the factory needs to return `oohttp.TLSConn` instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds an experimental factory for create proxying
TLS connections using uTLS rather than crypto/tls.
A user has requested this functionality.
For now, I'd like to avoid advertising it until I get confirmation
that this interface is okay for the user who requested it.
When it's confirmed it's okay, I'll change the README.
The v1 implementation of this functionality was in commit
d6f7e24. Yet, it turns out the
TLSClientFactory ended up having the wrong return type
(
*tls.Conn). This return type is incorrect; the factory needsto return
oohttp.TLSConninstead.