finish forking: remove net/http dep and ensure go build ./... works#1
Merged
bassosimone merged 3 commits intomainfrom Aug 12, 2021
Merged
finish forking: remove net/http dep and ensure go build ./... works#1bassosimone merged 3 commits intomainfrom
bassosimone merged 3 commits intomainfrom
Conversation
Verified we don't depend anymore from `net/http` by running:
```
go list -f '{{ .Imports }}' ./...|grep ' net/http'
```
We cannot access internal packages in the Go standard library. Here the simples action seems to just remove pprof. (This is not a problem for us, because we don't us it.)
We cannot import internal packages in the Go standard library. There is code in OONI that is using this functionality but it is deprecated code and we are going to remove it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is part of the effort to finish forking net/http. We want to entirely remove the net/http dependency and we want the code in the repository to build with
go build -v ./....