Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bare
search_web{"query":"weather"}call is renamed tosearchwhen the registered tools are['search', 'search_web']. This can select the wrong executor in chat or return the wrong function name through the API.Capture the exact name already matched by the regex instead of selecting it again with
startswith. Keep the nonempty-name guard so an empty tool list still produces no calls. JSON extraction and the returned content prefix are unchanged.Fixes #7666
Tests
python -m unittest discover -s tests -v: 10 standard-library tests passed on Python 3.12.15 and 3.13.16. Four regressions fail on unchanged source; six controls pass, including eleven other-format subcases.search; the fix runssearch_webwith the same arguments.modulescompilation, repository-configuredpycodestyle, additionalruff check, andgit diff --check: passed.No dependency changes. A full model/UI/API server was not run; the public parser and local tool loading/execution were exercised without mocking them.
Checklist: