Render CSS as an ERB partial instead of fetching from server #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 Would love to see this fix get merged. |
|
+1 |
Contributor
Author
|
@ono could we get this merged? We're getting many exceptions because of this on a Rails 5 project. Thanks for your work on this gem! |
Owner
|
Cool. I haven't used Rails or Resque for while so haven't tried this change by myself. But it seems to be a fair bug change so will merge and bump the version. Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 5 has a problem with this gem, mentioned here: #42. This PR makes it so that the CSS is served inline in the HTML, rendered as a partial.
Please check it out, thanks!