Clarify that op_type is case sensitive #4096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is consistent with current precedent. e.g. ONNX Runtime fails with "conv ... Error No Op registered for conv with domain_version of 7", as it must be "Conv". Signed-off-by: Dwayne Robinson <[email protected]>
Contributor
Author
|
FYI @jcwchen and @spandantiwari. |
jcwchen
added
topic: build
jcwchen
approved these changes
Mar 29, 2022
Member
jcwchen
left a comment
jcwchen
left a comment
There was a problem hiding this comment.
LGTM. Thank you for the spec clarification! Could @onnx/sig-archinfra-approvers please review it?
jcwchen
added
the
topic: spec clarification
gramalingam
approved these changes
Mar 29, 2022
wschin
pushed a commit
to wschin/onnx
that referenced
this pull request
Apr 12, 2022
This is consistent with current precedent. e.g. ONNX Runtime fails with "conv ... Error No Op registered for conv with domain_version of 7", as it must be "Conv". Signed-off-by: Dwayne Robinson <[email protected]>
broune
pushed a commit
to broune/onnx
that referenced
this pull request
May 6, 2023
This is consistent with current precedent. e.g. ONNX Runtime fails with "conv ... Error No Op registered for conv with domain_version of 7", as it must be "Conv". Signed-off-by: Dwayne Robinson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is consistent with current precedent. e.g. ONNX Runtime fails with "conv ... Error No Op registered for conv with domain_version of 7", as it must be "Conv".
Description
Motivation and Context