Skip to content

Conversation

@pk-g
Copy link
Contributor

@pk-g pk-g commented Feb 11, 2019

No description provided.

Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks ok. Please address the comments.

@pk-g
Copy link
Contributor Author

pk-g commented Mar 1, 2019

Thanks for the review, updated the PR with addressed feedback.

@pk-g pk-g closed this Mar 5, 2019
@pk-g pk-g reopened this Mar 5, 2019
@pengwa
Copy link
Contributor

pengwa commented Mar 6, 2019

shall we enhance this op to support reverse sequences of different lengths? in tf, it is called tf.reversesequence().

@pk-g
Copy link
Contributor Author

pk-g commented Mar 7, 2019

@pengwa If you are referring to the case where sequential data of different lengths has been padded, it may be cleaner to have a separate op to cover such scenario.

@pk-g pk-g force-pushed the reverse branch 2 times, most recently from cf94441 to 23bb003 Compare March 14, 2019 20:06
@pk-g
Copy link
Contributor Author

pk-g commented Mar 15, 2019

@linkerzhang, @houseroad: can you please review the updated PR so we can move ahead with this op? thanks.

@linkerzhang
Copy link
Member

@pk-g can you update the PR by fixing the conflicts?

@houseroad any more comments on this op please?

Thank you!

@pk-g pk-g merged commit 5be3e22 into onnx:master Mar 21, 2019
houseroad added a commit that referenced this pull request Mar 21, 2019
@houseroad
Copy link
Member

I will do the review later this week, but please don't rush.

Will revert it here: #1882

Please resubmit the changes.

houseroad added a commit that referenced this pull request Mar 21, 2019
@pk-g pk-g mentioned this pull request Mar 22, 2019
hariharans29 pushed a commit to hariharans29/onnx that referenced this pull request Aug 15, 2019
* Adding Reverse Op

* fixing merge conflicts
hariharans29 pushed a commit to hariharans29/onnx that referenced this pull request Aug 15, 2019
jcwchen pushed a commit to jcwchen/onnx that referenced this pull request Sep 23, 2020
* Adding Reverse Op

* fixing merge conflicts
jcwchen pushed a commit to jcwchen/onnx that referenced this pull request Sep 23, 2020
@fdwr
Copy link
Contributor

fdwr commented Oct 30, 2024

Will revert it here: #1882

Please resubmit the changes.

Was this op reverted and then simply forgotten to re-add? It's found in the following libraries...

...and we're looking to add it to WebNN for a voice to text model. It can be achieved in ONNX via the overloaded interpretation of setting ONNX Slice's to -1, but loses semantics and is more awkward (needing to specify starts: [2147483647, 2147483647], ends: [-2147483648, -2147483648], steps: [-1,-1], axes: [0,1] rather than just axes: [0,1]).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants