-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Adding Reverse op #1804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Reverse op #1804
Conversation
houseroad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks ok. Please address the comments.
|
Thanks for the review, updated the PR with addressed feedback. |
|
shall we enhance this op to support reverse sequences of different lengths? in tf, it is called tf.reversesequence(). |
|
@pengwa If you are referring to the case where sequential data of different lengths has been padded, it may be cleaner to have a separate op to cover such scenario. |
cf94441 to
23bb003
Compare
|
@linkerzhang, @houseroad: can you please review the updated PR so we can move ahead with this op? thanks. |
|
@pk-g can you update the PR by fixing the conflicts? @houseroad any more comments on this op please? Thank you! |
This reverts commit 5be3e22.
|
I will do the review later this week, but please don't rush. Will revert it here: #1882 Please resubmit the changes. |
* Adding Reverse Op * fixing merge conflicts
* Adding Reverse Op * fixing merge conflicts
Was this op reverted and then simply forgotten to re-add? It's found in the following libraries...
...and we're looking to add it to WebNN for a voice to text model. It can be achieved in ONNX via the overloaded interpretation of setting ONNX Slice's to -1, but loses semantics and is more awkward (needing to specify |
No description provided.