feat(skill-hub): move generated skills into build dir#9
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
|
hey @dhondtlaurens I’d love your take on where this landed. To me it fixes the main pain from #8 because skill generation no longer kicks in during regular could you install it and see if it works for you? Right now the control surface is basically If this still misses your use case for any reason, I’d really like to understand what part is still not working for you. We can still discuss adding a small CLI or programmatic entry afterward if matching the original issue more closely turns out to matter, but I’d rather understand the gap first :) |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6675f1c1ae
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a9aac4c99
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 63620677d9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Hey @onmax, thanks for working on this. The generationMode approach looks like exactly what I needed. prepare as the default solves the core issue from #8 since it keeps skill generation out of dev, build, and test runs while still auto-refreshing when things actually change during nuxt prepare. The source code changes look clean and straightforward. I couldn't install the preview due to unresolved catalog: references in the pkg.pr.new build, but no worries, I'll just update once this is merged and released. Looks good to me! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8a67351f0d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| sourceDir: resolve(contribution.sourceDir).replaceAll('\\', '/'), | ||
| sourceRoot: resolve(contribution.sourceRoot).replaceAll('\\', '/'), | ||
| sourceKind: contribution.sourceKind, | ||
| forceIncludeScripts: contribution.forceIncludeScripts, | ||
| hash: await hashDirectoryTreeIfExists(contribution.sourceDir), |
There was a problem hiding this comment.
The prepare-mode freshness key built in createLocalSourceFingerprints only includes path/hash/source-kind/script flags, so manual contribution metadata changes (for example version, repoUrl, docsUrl, official, resolver, sourceRepo/ref/path) are invisible to the fingerprint. Those fields are later rendered via generatedEntries in generateSkillTree, so changing them without modifying files can leave stale module metadata in the generated SKILL output because isGeneratedSkillFresh returns early.
Useful? React with 👍 / 👎.
2 participants
Fixes #8.
This moves the generated Nuxt skill tree into
buildDir/skill-hub/...and keeps only a small stableSKILL.mdwrapper in the mirrored agent skill root. The wrapper points agents to the generated content and tells them to runnuxt preparewhen the build-dir output is missing, which keeps the checked-in skill surface small and predictable.Generation now defaults to
skillHub.generationMode: 'prepare', runs on Nuxt's laterprepare:typeshook, and no longer does the heavy work during normaldevorbuildstartup. The install/docs flow was updated for the wrapper model, and the test suite now covers both the stable wrapper and the build-dir generation path.