Skip to content

perf(skill-hub): speed up skill resolution#13

Merged
onmax merged 3 commits intomainfrom
perf/skill-resolution-cache
Mar 27, 2026
Merged

perf(skill-hub): speed up skill resolution#13
onmax merged 3 commits intomainfrom
perf/skill-resolution-cache

Conversation

@onmax
Copy link
Copy Markdown
Owner

@onmax onmax commented Mar 27, 2026

Summary

  • move skill-hub snapshot and remote caches out of .nuxt so repeated prepares can restore generated skills instead of re-resolving modules
  • resolve unresolved remote package skills with bounded concurrency and memoized GitHub requests
  • keep the generated skill surface in .nuxt/skill-hub/... while making generation tests hermetic against the new persistent cache location

Verification

  • pnpm run lint
  • pnpm exec vitest run

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nuxt-skill-hub Ready Ready Preview, Comment Mar 27, 2026 9:33am

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 27, 2026

Open in StackBlitz

npm i https://pkg.pr.new/nuxt-skill-hub@13

commit: e5499f9

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 45077dbcf3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@onmax onmax merged commit 98fb240 into main Mar 27, 2026
5 checks passed
@onmax onmax deleted the perf/skill-resolution-cache branch March 27, 2026 09:34
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e5499f9f54

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +315 to +317
for (const ref of fallbackRefs) {
const resolved = await tryResolveForRef(ref, true)
if (resolved?.length) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Prefer version refs before default-branch heuristics

This ordering now resolves full GitHub heuristics (skills/ tree and path guesses) on fallbackRefs before retrying those same heuristics on version refs, so packages without agents.skills can return a main/master skill even when a version-matching tag (for the installed package version) exists. In practice, a package at v1.2.3 can incorrectly get main skill content and never reach the version ref loop, which can produce incompatible guidance for older module versions.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant