chore(workspace): refresh dependencies and test setup#33
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
nuxt-convex-playground | 6a3f7e2 | Commit Preview URL Branch Preview URL |
Mar 23 2026, 12:16 PM |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 56e9569c4e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Deployment failed with the following error: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 60918774df
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Fix default site URL assertion for non-production env
getPlaygroundSiteUrl now falls back to http://localhost:3000 unless NODE_ENV === 'production', so this assertion is no longer valid and will fail every run of the packages/nuxt unit project when called with {}. Keeping the old expectation blocks CI even though the helper behavior was intentionally changed in this commit.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd90c3d769
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6a3f7e2e21
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return getEnvValue(env, 'NUXT_PUBLIC_SITE_URL', 'SITE_URL') || DEFAULT_SITE_URL | ||
| export function getPlaygroundSiteUrl(env: EnvSource): string { | ||
| return getEnvValue(env, 'NUXT_PUBLIC_SITE_URL', 'SITE_URL') | ||
| || (env.NODE_ENV === 'production' ? DEFAULT_SITE_URL : DEFAULT_DEV_SITE_URL) |
There was a problem hiding this comment.
getPlaygroundSiteUrl now defaults to http://localhost:3000 outside production, but the Convex auth runtime still reads its default from playground/convex/env.ts (https://demo-nuxt-convex.onmax.me) and uses that value for trustedOrigins, cors.allowedOrigins, crossDomain({ siteUrl }), and secure-cookie behavior. In a local setup without explicit SITE_URL/NUXT_PUBLIC_SITE_URL, Nuxt and Convex resolve different origins, which can prevent local auth cookies/sessions from being set consistently and break the local sign-in flow this change is trying to improve.
Useful? React with 👍 / 👎.
1 participant
Uh oh!
There was an error while loading. Please reload this page.