Skip to content

chore: remove unenv AsyncLocalStorage patch#32

Merged
onmax merged 2 commits intomainfrom
chore/remove-unenv-patch
Mar 22, 2026
Merged

chore: remove unenv AsyncLocalStorage patch#32
onmax merged 2 commits intomainfrom
chore/remove-unenv-patch

Conversation

@onmax
Copy link
Copy Markdown
Owner

@onmax onmax commented Mar 22, 2026

Summary

  • Remove [email protected] patch that fixed AsyncLocalStorage.run/exit store restoration
  • Playground uses cloudflare-module preset with compatibility_date: 2025-12-11 — Workers provide native AsyncLocalStorage at that date, so the polyfill is never reached

Test plan

  • pnpm install clean
  • pnpm build passes
  • pnpm test — 11/11 files, 40/40 tests pass

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
convex Ready Ready Preview, Comment Mar 22, 2026 10:02am
nuxt-convex Ready Ready Preview, Comment Mar 22, 2026 10:02am

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Mar 22, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
nuxt-convex-playground ebdc068 Commit Preview URL

Branch Preview URL
Mar 22 2026, 09:59 AM

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 13526122d3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


patchedDependencies:
[email protected]: patches/[email protected]
catalog:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep unenv patch until all Worker targets use native ALS

Removing the patchedDependencies entry reverts [email protected] to its known broken AsyncLocalStorage.run/exit behavior for async callbacks (the deleted patch fixed store restoration after Promise completion), but this repo still includes a Worker target on compatibility_date: "2025-01-01" in wrangler.jsonc:4, which predates the native ALS date cited in the commit message. In that deployment path, request-scoped context can be lost or bleed across async boundaries, causing incorrect per-request state (for example auth/session context) under concurrent traffic.

Useful? React with 👍 / 👎.

@onmax onmax merged commit cdcdfe1 into main Mar 22, 2026
8 checks passed
@onmax onmax deleted the chore/remove-unenv-patch branch March 22, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant