Skip to content

feat(vue): harden standalone package and example#26

Merged
onmax merged 2 commits intomainfrom
maximogarciamtnez/onm-171-finish-and-harden-the-vue-primitives-package
Mar 19, 2026
Merged

feat(vue): harden standalone package and example#26
onmax merged 2 commits intomainfrom
maximogarciamtnez/onm-171-finish-and-harden-the-vue-primitives-package

Conversation

@onmax
Copy link
Copy Markdown
Owner

@onmax onmax commented Mar 19, 2026

Summary

  • harden the @onmax/convex-vue runtime around auth rebinding, keyed query resubscription, pagination recovery, and upload validation
  • expand Vue package coverage for auth, runtime facade, and upload edge cases without changing the public entrypoint split
  • replace the static Vite example with a real standalone task and upload workflow, plus the minimum storage support/docs sync needed for that flow

Testing

  • pnpm --filter @onmax/convex-vue typecheck
  • pnpm --filter @onmax/convex-vue test
  • pnpm --filter convex-vue-example build

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 19, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
convex Ready Ready Preview, Comment Mar 19, 2026 1:55pm
nuxt-convex Ready Ready Preview, Comment Mar 19, 2026 1:55pm

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Mar 19, 2026 •
edited
Loading

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs		 nuxt-convex-playground 53d915a Commit Preview URL

Branch Preview URL		 Mar 19 2026, 01:53 PM

@onmax onmax force-pushed the maximogarciamtnez/onm-171-finish-and-harden-the-vue-primitives-package branch from 14d727c to 6e8d579 Compare March 19, 2026 13:38
@chatgpt-codex-connector
Copy link
Copy Markdown

chatgpt-codex-connector bot commented Mar 19, 2026

💡 Codex Review

nuxt-convex/packages/nuxt/src/runtime/composables/useConvexR2Upload.ts

Line 75 in 14d727c

const client = useConvexClient()

P1 Badge Capture Convex client during composable initialization

upload() now calls useConvexClient() at invocation time, but that helper depends on Vue inject context and is only guaranteed during composable setup. In normal usage (upload triggered by a click/input event), this can throw [convex-vue] Convex plugin context not found before any network call. Because the call is also outside the try/catch, the hook skips error state updates and onError, and callers get a rejected promise instead of the documented null failure path.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@onmax onmax merged commit 6b940f8 into main Mar 19, 2026
8 checks passed
@onmax onmax deleted the maximogarciamtnez/onm-171-finish-and-harden-the-vue-primitives-package branch March 19, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@onmax