Skip to content

Fix of errors reported by the sample aggregator. Invalid sample.json #1652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
IgorOchocki merged 1 commit into from
May 12, 2023
Merged

Fix of errors reported by the sample aggregator. Invalid sample.json #1652

IgorOchocki merged 1 commit into from
May 12, 2023

Conversation

@amakarev
Copy link
Contributor

@amakarev amakarev commented May 12, 2023

Existing Sample Changes

Description

After adding some samples, the sample aggregator started reporting errors in the validation of sample.json files. In two samples, due to a categories field that doesn't fit the format, json files turned out to be invalid:

iotdk-ninja
iotdk-ninja
10.64.105.26 10.64.69.172 172.17.0.1 
Sample branch/tag: development

The following error was seen in function isValid()

In the sample named:
convolutionSeparable

The error message is:
[{"instancePath":"/categories/0","schemaPath":"#/properties/categories/items/pattern","keyword":"pattern","params":{"pattern":"^(Toolkit/.*[^/])$"},"message":"must match pattern \"^(Toolkit/.*[^/])$\""}]


iotdk-ninja
iotdk-ninja
10.64.105.26 10.64.69.172 172.17.0.1 
Sample branch/tag: development

The following error was seen in function isValid()

In the sample named:
quasirandomGenerator

The error message is:
[{"instancePath":"/categories/0","schemaPath":"#/properties/categories/items/pattern","keyword":"pattern","params":{"pattern":"^(Toolkit/.*[^/])$"},"message":"must match pattern \"^(Toolkit/.*[^/])$\""}]

Samples:
quasirandomGenerator
convolutionSeparable
Fixes Issue#
https://jira.devtools.intel.com/browse/ONSAM-1601
https://jira.devtools.intel.com/browse/ONSAM-1599

External Dependencies

List any external dependencies created as a result of this change.

Type of change

  • Implement fixes for ONSAM Jiras

How Has This Been Tested?

Manual testing. Debugging with sample-aggregator

  • oneapi-cli

@amakarev amakarev changed the title fixed categories field Fix of errors reported by the sample aggregator. Invalid sample.json May 12, 2023
@IgorOchocki IgorOchocki merged commit ee455ab into oneapi-src:development May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IgorOchocki IgorOchocki IgorOchocki approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amakarev @IgorOchocki