Fix of errors reported by the sample aggregator. Invalid sample.json #1649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ShwethaSelma @ManjulaChalla @jimmytwei |
IgorOchocki
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing Sample Changes
Description
After adding some samples, the sample aggregator started reporting errors in the validation of sample.json files. In three samples, due to a missing comma, json files turned out to be invali
Fixes Issue#
https://jira.devtools.intel.com/browse/ONSAM-1601
https://jira.devtools.intel.com/browse/ONSAM-1600
https://jira.devtools.intel.com/browse/ONSAM-1599
External Dependencies
List any external dependencies created as a result of this change.
Type of change
How Has This Been Tested?
Manual testing. Debugging with sample-aggregator