Conversation
The -s would be replaced with -a during conversion anyway. Confirmed that the resulting XML file has no diffs.
This was referenced Apr 23, 2025
fcbond
approved these changes
May 22, 2025
Contributor
fcbond
left a comment
fcbond
left a comment
There was a problem hiding this comment.
Looks good to me, thanks.
Definitely not helpful to keep the '-s' around, or non-linked synsets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does two things:
-ssynset IDs with-afor nld, lit, and slk. This happened anyway during conversion to WN-LMF, but for some reason the.tabfiles still retained the-sIDs. I confirmed that the resulting XML files had no diffs.The list of removed entries, from #24, is as follows:
The removals are noted in the
*-changes.tabfiles, but the-sto-amodifications are not (it's trivial, and there are thousands of them).