Skip to content

Allow alternative forms for Arabic#56

Merged
goodmami merged 2 commits intomainfrom
gh-46-arabic-forms
Mar 10, 2025
Merged

Allow alternative forms for Arabic#56
goodmami merged 2 commits intomainfrom
gh-46-arabic-forms

Conversation

@goodmami
Copy link
Copy Markdown
Collaborator

This PR does the following:

  • Normalized 'arb:lemma:brokenPlural' to 'arb:lemma:brokenplural' in the TSV file
  • Adds support for creating alternative forms on a synset when a lemma is already defined
    • lemma:brokenplural creates a form with <Tag category="number">plural</Tag>
    • lemma:root creates a form with <Tag category="form">root</Tag> when it differs from the primary lemma
  • Revises the unit tests for tsv2lmf.py to be more modular
  • Adds an --abort-on-errors option to tsv2lmf.py; if the option is not set, any TSV2LMFErrors only trigger a log and don't immediately stop processing

goodmami added 2 commits March 9, 2025 12:27
* `arb:lemma:root` is added as a Form if it differs from the primary lemma
* `arb:lemma:brokenplural` is added as an alternative form
* Both of the above are only added if the preceding synset matches and a lemma
  has been defined.

Resolves #46
@goodmami goodmami merged commit e18e0cd into main Mar 10, 2025
@goodmami goodmami deleted the gh-46-arabic-forms branch March 11, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant