Merged
Conversation
* Report exact and normalized duplicates separately * Add support for polysemy thresholds
Replace '_' with ' ', strip quotes, and remove exact duplicate lemmas.
Use --ignore-lemma-type to only look at lemmas. This is mainly for the Arabic wordnet which uses lemma types like arb:lemma:root and arb:lemma:brokenplural.
This makes it more consistent with clean-tsv.py and makes it more amenable to scripting or CI uses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making a separate PR from #33 just for the scripts, and actually cleaning up the data can go in other PRs.
This PR adds two scripts:
scripts/tsv-duplicates.pyfinds exact and normalized redundant lemmasscripts/clean-tsv.pymodifies TSV files (in-place to stdout) to strip quotes, replace_with a space, and remove duplicate lemmas in a synset.The normalized duplicates of
tsv-duplicates.pyare probably best fixed by hand, soclean-tsv.pyonly looks for exact duplicates after some basic cleaning.@fcbond I reused parts of your quote-stripping code from the other PR, so we might not need it in two places. Better to do it once and modify the TSV than to do it every time we create a WN-LMF file, I think.