Feature/emoji-find#53
Merged
Merged
Conversation
added 11 commits
July 16, 2017 15:44
omnidan
reviewed
Jul 21, 2017
| * @param {string} nameOrCode The emoji to find, either `coffee`, `:coffee:` or `☕`; | ||
| * @return {object} | ||
| */ | ||
| Emoji.find = function get(nameOrCode) { |
Owner
There was a problem hiding this comment.
can you rename the function to find (could be confusing to see get in the stack trace when this is the find function)?
we should always ensure that the internal function name (function functionName) is the same as the API function name (Emoji.functionName):
Emoji.functionName = function functionName (arguments) {
Owner
|
thanks for all the PRs! this PR looks good, except that the function names are not defined properly. I'll merge it and update the names 😁 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
Emoji.findmethod. This PR is build upon #52, so either that one should be merged first, or this one should be refactored.Readme should also cover
Emoji.findByNameandEmoji.findByCode, but I think the readme could use a general makeover. So I wanted to postpone that change, to keep the upcoming release more agile.Emoji.findis covered by the readme update.This PR turnes the tests below green: