Feature/refactor#52
Merged
Merged
Conversation
added 8 commits
July 16, 2017 15:44
Merged
Owner
|
looks good - thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like a lot of changes, so best if you review them per commit. At the end; it's just some vars being renamed, the helper functions are moved to the top. And the
module.exportto the bottom.The reversed dictionary, is now stored in a normalized way, so all emojis (keys) there are in text form. Making it more easy to do lookups, as there are no differences regarding to with or without
non-spacing-mark.The
whichas been improved to use the normalized reversed dictionary, and thereby improved in performance.