Refactoring plugin-initial code structure - part 3: Organizing Omise_Admin class #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonrandy
reviewed
Jan 18, 2019
omise-woocommerce.php
Outdated
| */ | ||
| public function init_error_messages(){ | ||
| ?> | ||
| <div class="error"> |
There was a problem hiding this comment.
Again, this REALLY feels wrong. Does WP advocate this?
There was a problem hiding this comment.
Welcome to WordPress world.
I cannot tell if WP advocates for this but the WP codebase is even worse..
But yup, this is kind of common thing in WordPress (even WooCommerce and many plugins also go with this way everywhere in their code).
We can go a little advance by moving this thing into a template file and load it but I guess that would be out of scope for this pull request. Maybe we can discuss further in a future PR :)
omise-woocommerce.php
Outdated
| public function init_error_messages(){ | ||
| ?> | ||
| <div class="error"> | ||
| <p><?php echo __( 'Omise WooCommerce plugin requires <strong>WooCommerce</strong> to be activated.', 'omise' ); ?></p> |
There was a problem hiding this comment.
👍 This will be automatically solved after merge #94
guzzilar
force-pushed
the
refactoring-plugin-initiating-structure-part3
branch
from
8d0bb07 to
d7f349b
Compare
jacstn
approved these changes
Jan 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
Omise-WooCommerce has always been coupled with WooCommerce plugin, which the plugin cannot be used as a stand-alone plugin and always require WooCommerce plugin to be activated first.
However, the legacy-codebase itself wasn't really aware of a case where WooCommerce plugin is disabled as much as it should be.
Although we have prevented such cases #78, and #83. But by the current design of the plugin-initial step, it still remains some issue (#90) that could be ceased out by redesigning the initial-step with a proper awareness of WooCommerce plugin.
Related issue(s):
2. Description of change
Part 1
See, #94: "Refactoring plugin-initial code structure, part 1"
Part 2
See, #95: "Refactoring plugin-initial code structure, part 2"
Part 3
The last piece of code,
This part is aiming to organizing
Omise_Adminclass, by moving all admin-related code fromOmiseclass back toOmise_Admin.3. Quality assurance
🔧 Environments:
✏️ Details:
The main test-case will be separated into 3 cases as follows:
Omise-WooCommerce plugin can be activated, but all functions should be disabled, including no Omise menu at the WordPress admin-sidebar.
4. Impact of the change
No
5. Priority of change
Normal
6. Additional Notes
No