Fix WooCommerce version number hasn't been shown properly at user-agent #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…WC exists instead of check class exists.
jacstn
approved these changes
Apr 20, 2018
|
👍 |
This was referenced Apr 20, 2018
|
test integration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
Currently the WooCommerce version number can't be shown at the user-agent.
This PR is bringing the version number back.
2. Description of change
• At the moment the code does user-agent assignment, check if function WC exists instead of check class existing.
3. Quality assurance
🔧 Environments:
✏️ Details:
• Make sure that WooCommerce version number is assigned to USER-AGENT properly when create charges.
Just make an order as normal, then check at the Omise Dashboard, now we should see 'WooCommerce version number' at the user-agent section of charge's log.
4. Impact of the change
No
5. Priority of change
High
6. Additional Notes
No