Fix that user cannot use saved-card at the checkout page. Also, better credit card form UI #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
WooCommerce html-renderer has been changed in v3.x cause that user cannot use a 'saved-card' to perform a checkout at the checkout page.
Related information:
Related issue(s): No
2. Description of change
Correct HTML structure at the credit card form to proper display saved-card list.
Also enhance the credit card form UI (basically, makes credit card form UI corresponding to the new Omise.js UI).
3. Quality assurance
🔧 Environments:
✏️ Details:
✅ 3.1. Test create a charge first time with a new-registered user account without saving card
Expectation Charge must be created properly.
✅ 3.2. Second time, try create another charge, now, save your card
Expectation Charge must be created properly and a
customerobject must be created and attach a new card.✅ 3.3. Now, try use the card that you just saved to charge
Expectation Charge must be created properly with your new saved-card.
✅ 3.4. Try create another charge. But this time you will choose to 'Create a card using new card' option
Expectation Charge must be created properly.
4. Impact of the change
Credit card form UI changed.
Need to re-translate labels & texts in the credit card form.
5. Priority of change
High
6. Additional Notes
No.