[ENGA3-835]: Fix the compatible issue with PHP 7.2 and below. #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…owing error on PHP 7.2 and below.
ajzkk
approved these changes
Jan 19, 2023
new4762
approved these changes
Jan 19, 2023
aashishgurung
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
Fix the compatible issue with PHP 7.2 and below.
Jira Ticket: #835
2. Description of change
Removed the comma at the end of second argument of
sprintfbecause we don't have a third parameter.3. Quality assurance
Switch PHP version to 7.2 or below in docker and run the docker. Once container is up, go to the setting page. You should now see any error.
🔧 Environments: