Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENGA3-518]: Fix the issue of customer getting back to checkout page from OTP page. #323

Merged
merged 6 commits into from
Oct 28, 2022

Conversation

aashishgurung
Copy link
Contributor

1. Objective

Fix the issue of customer getting back to checkout page from OTP page.

Jira Ticket: #518

2. Description of change

There was no way of reproducing this issue in staging and for production, we don't have live credit card. Our only option was to scan the code.

We assume that the includes/class-omise-callback.php return customer to the checkout page because plugin thought the redirect URL was triggered by user. The reason should be the headers we rely on had a differently value. Previously, we added token in redirect URL for mobile banking only.

To fix this we added token in the return URL for all remaining payment methods except offline and OCBC PAO. After this change, we rely on headers for OCBC PAO only because for some reason we can send query params in redirect URL for OCBC PAO.

3. Quality assurance

Using test account of staging environment, test the following payment methods. Success and failure should redirect to appropriate page.

Thailand

  • Credit / Debit Card ✅
  • Installments ✅
  • Internet Banking ✅
  • Mobile Banking ✅
  • PromptPay ✅
  • TrueMoney Wallet ✅
  • Rabbit LINE Pay ✅
  • GrabPay ✅
  • GooglePay ✅
  • ShopeePay ✅

Malaysia

  • Online Banking (FPX) ✅
  • Credit card ✅
  • Installments ✅
  • Touch ’n Go eWallet ✅
  • GrabPay ✅
  • GooglePay ✅
  • Boost ✅
  • ShopeePay ✅
  • Maybank QRPay ✅
  • DuitNow QR ✅
  • DuitNow Online Banking/Wallets ✅

Singapore

  • Credit card ✅
  • Alipay (Alipay+™ Partner) ✅
  • AlipayHK (Alipay+™ Partner) ✅
  • DANA (Alipay+™ Partner) ✅
  • GCash (Alipay+™ Partner) ✅
  • Kakao Pay (Alipay+™ Partner) ✅
  • GrabPay ✅
  • ShopeePay ✅

Japan

  • Credit card ✅
  • Convenience Store / Pay-easy / Online Banking ✅
  • GooglePay ✅

🔧 Environments:

  • WooCommerce: v6.7.0
  • WordPress: v6.0.2
  • PHP version: 8.1
  • Omise WooCommerce: 4.25.0

@aashishgurung aashishgurung requested a review from ajzkk as a code owner October 26, 2022 07:02
@aashishgurung aashishgurung changed the title Feature/enga3 518 [ENGA3-518]: Fix the issue of customer getting back to checkout page from OTP page. Oct 27, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 21 Code Smells

No Coverage information No Coverage information
27.6% 27.6% Duplication

@aashishgurung aashishgurung merged commit a18efe9 into master Oct 28, 2022
@aashishgurung aashishgurung deleted the feature/ENGA3-518 branch August 18, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants