[ENGA3-518]: Fix the issue of customer getting back to checkout page from OTP page. #323
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
Fix the issue of customer getting back to checkout page from OTP page.
Jira Ticket: #518
2. Description of change
There was no way of reproducing this issue in staging and for production, we don't have live credit card. Our only option was to scan the code.
We assume that the
includes/class-omise-callback.php
return customer to the checkout page because plugin thought the redirect URL was triggered by user. The reason should be the headers we rely on had a differently value. Previously, we added token in redirect URL for mobile banking only.To fix this we added token in the return URL for all remaining payment methods except offline and OCBC PAO. After this change, we rely on headers for OCBC PAO only because for some reason we can send query params in redirect URL for OCBC PAO.
3. Quality assurance
Using test account of staging environment, test the following payment methods. Success and failure should redirect to appropriate page.
Thailand
Malaysia
Singapore
Japan
🔧 Environments: