Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENGA3-458]: Fixed the credit card form's UI issue with default theme #322

Merged
merged 1 commit into from
Oct 25, 2022
Merged

[ENGA3-458]: Fixed the credit card form's UI issue with default theme #322

merged 1 commit into from
Oct 25, 2022

Conversation

aashishgurung
Copy link
Contributor

@aashishgurung aashishgurung commented Oct 21, 2022 •
edited
Loading

1. Objective

Fix the broken remember card option in CC UIin default theme.

Jira Ticket: #458

2. Description of change

Fixed the layout using CSS Flexbox. Added CSS classes and updated some CSS property value.

3. Quality assurance

  • Switch to twenty twenty-two theme
  • Go to checkout page
  • Choose credit card payment

Before

Screen Shot 2565-10-21 at 14 53 27

After

Screen Shot 2565-10-21 at 14 52 33

🔧 Environments:

  • WooCommerce: v6.7.0
  • WordPress: v6.0.2
  • PHP version: 8.1
  • Omise WooCommerce: 4.25.0

@aashishgurung aashishgurung requested a review from ajzkk as a code owner October 21, 2022 09:14
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aashishgurung aashishgurung merged commit 04337f2 into master Oct 25, 2022
@aashishgurung aashishgurung mentioned this pull request Oct 28, 2022
Merged
@aashishgurung aashishgurung deleted the feature/ENGA3-458-CC-UI-fix branch August 18, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kan98 kan98 kan98 approved these changes

@davidhanh davidhanh davidhanh approved these changes

@new4762 new4762 new4762 approved these changes

@ajzkk ajzkk ajzkk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aashishgurung @kan98 @davidhanh @new4762 @ajzkk