[ENGA3-420]: Updated Omise_Capabilities class to prevent calling capabilities API when the keys are null. #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bilities API when the keys are null.
aashishgurung
requested review from
kan98,
FhanOmise,
new4762,
ajzkk,
hpariwat and
tookaa2
new4762
approved these changes
Sep 5, 2022
ajzkk
approved these changes
Sep 5, 2022
added 2 commits
September 5, 2022 15:14
…e check for any falsy value. Added a comment.
|
Kudos, SonarCloud Quality Gate passed!
|
kan98
approved these changes
Sep 6, 2022
FhanOmise
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
Prevent calling capabilities API when the keys are null.
Jira Ticket: #420
2. Description of change
Updated
Omise_Capabilitiesclass to prevent calling capabilities API when the keys are null. Added a check that compares the newly fetched keys with the previously saved keys. If the keys are different then then we call to capabilities API else we return previously built instance.🔧 Environments: