[ENGA3-324]: Added Japanese translation for the error messages. #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… due to invalid card info. Added some other missing translation as well.
aashishgurung
requested review from
som-m,
kan98,
FhanOmise,
new4762,
ajzkk,
hpariwat and
tookaa2
|
Kudos, SonarCloud Quality Gate passed!
|
hpariwat
approved these changes
Aug 31, 2022
aashishgurung
changed the title
kan98
approved these changes
Aug 31, 2022
new4762
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
Add Japanese translation for the error messages due to invalid card info. Added some other missing translation as well.
Jira Ticket: #324
2. Description of change
assets/javascripts/omise-payment-form-handler.jsto converted the message received as API response to the Japanese language.includes/class-omise-wc-myaccount.phpandincludes/gateway/abstract-omise-payment-base-card.php, we added the required translation texts to the variable that needs to be passed to the JS file.3. Quality assurance
First, change site language to Japanese. You can follow this link for assistance. Now, you must replace the
omise-ja.poandomise-ja.mopresent in the container's foldervar/www/html/wp-content/languages/plugins. Assuming you are in the root of our omise-woocommerce plugin, use the following command to copyomise-ja.poandomise-moinside docker container.🔧 Environments: