Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix v4.23 #294

Merged
merged 9 commits into from
Aug 18, 2022
Merged

Fix v4.23 #294

merged 9 commits into from
Aug 18, 2022

Conversation

FhanOmise
Copy link
Contributor

1. Objective

  • Revert v4.23.1 back
  • Fix error show on admin page when cannot get capability.

2. Description of change

  • Revert v4.23.1 back
  • handle error when cannot get capability.

3. Quality assurance

Admin page not show error message when cannot get capability eg. no keys. Checkout page working properly and charge can be created.

🔧 Environments:

  • WooCommerce: v6.7.0
  • WordPress: v6.0.1
  • PHP version: 7.3.3

4. Impact of the change

5. Priority of change

Normal.

6. Additional Notes

Any further information that you would like to add.

@FhanOmise FhanOmise marked this pull request as ready for review August 8, 2022 08:35
@FhanOmise FhanOmise requested a review from som-m August 10, 2022 02:50
Copy link
Contributor

@aashishgurung aashishgurung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 13 Code Smells

No Coverage information No Coverage information
65.3% 65.3% Duplication

@FhanOmise FhanOmise merged commit b7f7750 into master Aug 18, 2022
@FhanOmise FhanOmise mentioned this pull request Aug 18, 2022
aashishgurung pushed a commit that referenced this pull request Aug 29, 2022
This reverts commit b7f7750, reversing
changes made to 07d3cf8.
FhanOmise added a commit that referenced this pull request Aug 29, 2022
This reverts commit b7f7750, reversing
changes made to 07d3cf8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants