Update payment render #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpariwat
reviewed
Aug 2, 2022
tookaa2
reviewed
Aug 3, 2022
hpariwat
approved these changes
Aug 9, 2022
Co-authored-by: aashishgurung <[email protected]>
…merce into update-payment-render
Co-authored-by: aashishgurung <[email protected]>
…merce into update-payment-render
This reverts commit fd0ce38.
FhanOmise
approved these changes
Aug 16, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
tookaa2
approved these changes
Aug 18, 2022
aashishgurung
pushed a commit
that referenced
this pull request
Aug 29, 2022
This reverts commit c1c925b.
aashishgurung
pushed a commit
that referenced
this pull request
Aug 29, 2022
This reverts commit c1c925b.
FhanOmise
added a commit
that referenced
this pull request
Aug 29, 2022
This reverts commit c1c925b.
aashishgurung
added a commit
that referenced
this pull request
Aug 30, 2022
* Revert "Update payment render (#290)" This reverts commit c1c925b. * Revert "[ENGA3-290]: Issue of displaying an error as an option of Online bank… (#296)" This reverts commit 665d76e. * Revert "fix release date" This reverts commit 3955645. * Revert "Update changelog" This reverts commit 66a4b73. * Revert "Release 4.23.2" This reverts commit f97965d. * Revert "Handle console error when fpx bank list is empty" This reverts commit 097938a. * Revert "remove release" This reverts commit df62a9f. * Revert "Update capabilities calling" This reverts commit 1178a7b. * Revert "update v4.23.2" This reverts commit ee6b493. * Revert "Handle retrive capabilities error" This reverts commit c3585af. * Revert "Revert "Revert "Merge pull request #287 from omise/add-rms""" This reverts commit ec0e648. * Revert "Revert "Revert "Feature/plugins 269 (#288)""" This reverts commit 02791e2. * Revert "Revert "Revert "Feature/plugins 245 (#285)""" This reverts commit 397a95c. * Revert "Revert "Revert "[PLUGINS-257: Sec-fetch header is checked to determine whether the request is a user originated operation or not. (#284)""" This reverts commit 654ffde.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
Currently our plugin is showing payment methods that omise account of merchants is can’t support it
So this pr is focused on improving customer & merchants experience by display only payment that they can make a pay
and help ours developer to support new payment method without need to waiting to deploy on production
This section will be used in the release notes.
Related information:
Related issue(s): #< GitHub ticket number > (optional)
2. Description of change
Omise_Paymentto support source_typeis_availableto filter list to render payment methods on checkout page3. Quality assurance
All setting can make a change and payment method is display correctly
and try make null setting for test backward compatible for ours plugin
🔧 Environments:
✏️ Details:
try switch omise account or update source_type on admin dashboard for testing
is showing payment methods correctly
4. Impact of the change
Display only payment methods that available from capabilities
5. Priority of change
Normal
6. Additional Notes
Any further information that you would like to add.