Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/plugins 245 #285

Merged
merged 4 commits into from
Jul 11, 2022
Merged

Feature/plugins 245 #285

merged 4 commits into from
Jul 11, 2022

Conversation

aashishgurung
Copy link
Contributor

1. Objective

Add missing localization on my card section

Jira: #245

2. Description of change

Changed the plain English text to a translated text using WP's __e() function.

3. Quality assurance

  • Checkout with a card and save the card
  • Go to My Account. You should see following screen.

Now
Screen Shot 2565-07-07 at 15 01 56

Before
Screen Shot 2565-07-07 at 15 03 45

🔧 Environments:

  • WooCommerce: v6.4.1
  • WordPress: v5.9.3
  • PHP version: 7.3.33
  • Omise plugin version: Omise-WooCommerce 4.22.0

Aashish added 2 commits July 5, 2022 17:07
… text added from Google translate for testing purpose. Real translation will be added once we receive it.
Copy link
Contributor

@som-m som-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@som-m
Copy link
Contributor

som-m commented Jul 11, 2022

@aashishgurung Just saw "Delete". Could we add this too ka?

…d. Translation text added from Google translate for testing. Waiting for the actual translation text.
@aashishgurung
Copy link
Contributor Author

@aashishgurung Just saw "Delete". Could we add this too ka?

Sure. I have already asked for the Japanese translation. I am waiting for it.

@som-m
Copy link
Contributor

som-m commented Jul 11, 2022

👍

image

@aashishgurung aashishgurung merged commit 29e1086 into master Jul 11, 2022
FhanOmise added a commit that referenced this pull request Aug 4, 2022
FhanOmise added a commit that referenced this pull request Aug 8, 2022
@aashishgurung aashishgurung deleted the feature/PLUGINS-245 branch August 29, 2022 12:04
aashishgurung pushed a commit that referenced this pull request Aug 29, 2022
aashishgurung added a commit that referenced this pull request Aug 30, 2022
* Revert "Update payment render (#290)"

This reverts commit c1c925b.

* Revert "[ENGA3-290]: Issue of displaying an error as an option of Online bank… (#296)"

This reverts commit 665d76e.

* Revert "fix release date"

This reverts commit 3955645.

* Revert "Update changelog"

This reverts commit 66a4b73.

* Revert "Release 4.23.2"

This reverts commit f97965d.

* Revert "Handle console error when fpx bank list is empty"

This reverts commit 097938a.

* Revert "remove release"

This reverts commit df62a9f.

* Revert "Update capabilities calling"

This reverts commit 1178a7b.

* Revert "update v4.23.2"

This reverts commit ee6b493.

* Revert "Handle retrive capabilities error"

This reverts commit c3585af.

* Revert "Revert "Revert "Merge pull request #287 from omise/add-rms"""

This reverts commit ec0e648.

* Revert "Revert "Revert "Feature/plugins 269 (#288)"""

This reverts commit 02791e2.

* Revert "Revert "Revert "Feature/plugins 245 (#285)"""

This reverts commit 397a95c.

* Revert "Revert "Revert "[PLUGINS-257: Sec-fetch header is checked to determine whether the request is a user originated operation or not. (#284)"""

This reverts commit 654ffde.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants