[APM2-695] FPX logo, banklist and terms & condition #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tookaa2
reviewed
May 23, 2022
Co-authored-by: Ponpol Wongsapjinda <[email protected]>
som-m
reviewed
May 23, 2022
Co-authored-by: Som <[email protected]>
som-m
approved these changes
May 24, 2022
@som-m do you mean spacing top down between components right krub |
Add Bank of China Logo for FPX
kan98
reviewed
May 24, 2022
kan98
reviewed
May 24, 2022
kan98
reviewed
May 24, 2022
Co-authored-by: aashishgurung <[email protected]>
kan98
approved these changes
May 24, 2022
|
working correctly krub. |
@tanawin-opn Thanks for the review krub 🙏 |
tookaa2
approved these changes
May 25, 2022
aashishgurung
approved these changes
May 25, 2022
|
This PR will release after 2nd June (should be 6th June) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
FPX Logo and terms and condition was missing , and bank options is not well ux for customer
so this PR will update FPX Logo and terms and condition and changes radio option to be selection.
This section will be used in the release notes.
Related information:
Related issue(s): https://omise.atlassian.net/browse/APM2-695
2. Description of change
3. Quality assurance
Specify where and how you tested this and what further testing it might need.
🔧 Environments:
WooCommerce: v6.2.2
WordPress: v5.9.1
PHP version: 7.3.33
Omise plugin version: Omise-WooCommerce 4.20
✏️ Details:
Using Malaysia key to create FPX charges and make sure charges is create correctly
4. Impact of the change
5. Priority of change
Normal
6. Additional Notes
Any further information that you would like to add.