fix other payment won't send email on on-hold order #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nimitomise
requested review from
FhanOmise,
hpariwat,
jutinapas,
kan98 and
tookaa2
hpariwat
approved these changes
Dec 14, 2021
tookaa2
approved these changes
Dec 14, 2021
kan98
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix issue when user make a payment via non omise payment then order email for on-hold status won't be send to merchant
Non Omise Payment will always send email to merchant for order with status on-hold
When user make payment with non Omise payment then order email with status on-hold will always send to the merchant but with Omise payment there should be no order email with status on-hold send to the merchant
🔧 Environments:
Tested locally by pointing OMISE_API_URL to Staging
WooCommerce: v5.7.1
WordPress: v5.8
PHP version: 7.1
No impact, this is to ensure the behavior remains the same as before
High