[EM-616] Add support for FPX payment #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ashraf-alkibsi
approved these changes
Jul 14, 2021
kan98
reviewed
Jul 14, 2021
kan98
reviewed
Jul 14, 2021
kan98
reviewed
Jul 14, 2021
hpariwat
approved these changes
Jul 14, 2021
danfowler
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
Explain in non-technical terms WHY this PR is required.
E.g.: What feature it adds, what problem it solves...
Add support for new alternative payment method FPX
Related information:
2. Description of change
Added bank logos for FPX and FPX payment method to woocommerce plugin
To support market in Malaysia, we added the FPX payment.
3. Quality assurance
Specify where and how you tested this and what further testing it might need.
🔧 Environments:
Tested on local woocommerce but with capabilities pointing to production api
i.e.
✏️ Details:
4. Impact of the change
List the steps that must be taken for this PR to work.
E.g.: rake yak:shave, Add "yak_key" to environment variables, ...
Be sure to include all systems that needs to be changed or which system is affected by the change
(Ex: Requires Elastic search to be installed and configured in secrets.yml).
Note: Please provide a screenshot if your changed impact to UI.
5. Priority of change
Normal
6. Additional Notes
FPX banks availability will be fetched from capabilities api, if bank is offline the offline label will be shown