[EM-611] Unable to view PromptPay QR after downloading from email #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ashraf-alkibsi
approved these changes
Jul 13, 2021
tookaa2
approved these changes
Jul 13, 2021
som-m
approved these changes
Jul 14, 2021
The thank you page will never expire by default. It would be good to have as a reference for customers. If the payment is made from an account and not by a guest, it should only be available when the user is logged in. These are all WooCommerce's policies. Our plugin wise, we only show the QR code and download button if the charge is still pending on our side. So if the charge is successful or failed, we won't show the QR code on the thank you page. |
hpariwat
approved these changes
Jul 16, 2021
danfowler
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
Explain in non-technical terms WHY this PR is required.
E.g.: What feature it adds, what problem it solves...
This section will be used in the release notes.
When a customer creates an order and chooses Promptpay as their payment method, we send an order received in the email. The email includes the link to download the QR code to pay with, problem is the image is in an SVG format which isn't an ideal for customers to pay with. For many systems, there default application to open SVG images are a text editor to show it's XML.
Related information:
Related issue(s): #< GitHub ticket number > (optional)
2. Description of change
A general description of WHAT changed in the codebase, but short of an English version of the diff. Assume that people reading this will also be looking at the output of
git diffand guide them to the highlights.Additionally add the reasoning for change details if they're complex or abstract.
Firstly, the email links to the order received woocommerce page instead of the image download link. Then in that page, we add a download image link to download the image as an SVG.
We add a script that runs on the page to create a canvas from the SVG and then create a PNG download link from that canvas. If the browser doesn't support the use of canvas, we will fallback to downloading the original SVG image instead. However, most modern browsers supports canvas so users should be able to get the PNG image.
3. Quality assurance
Specify where and how you tested this and what further testing it might need.
Tested on Chrome, Firefox and Safari on Mac OS. Since we have a fallback to SVG and all the tests I conducted passed, I think it's OK to not test on more browsers.
🔧 Environments:
Specify the details of your test environments, including, for each, the platform version (on which the plugin was run), the Omise plugin version, and the versions of your system software such as PHP or Ruby.
i.e.
✏️ Details:
Explain how to manually test this feature.
For example if changes were made in the UI or in the API, explain where and if any specific access is needed.
Create a Promptpay charge on test/live mode and download the PNG. Also go to your email and click the link to come back to the order page and download the PNG.
4. Impact of the change
List the steps that must be taken for this PR to work.
E.g.: rake yak:shave, Add "yak_key" to environment variables, ...
Be sure to include all systems that needs to be changed or which system is affected by the change
(Ex: Requires Elastic search to be installed and configured in secrets.yml).
Note: Please provide a screenshot if your changed impact to UI.
qr_code.png
5. Priority of change
Normal, High or Immediate.
Normal
6. Additional Notes
Any further information that you would like to add.