Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove QR from email when charge is no longer pending #219

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Remove QR from email when charge is no longer pending #219

merged 1 commit into from
Jun 30, 2021

Conversation

som-m
Copy link
Contributor

@som-m som-m commented Jun 25, 2021

1. Objective

Remove PayNow QR from email when charge is no longer pending.

Related information:
Related issue(s): internal ticket CS-675

2. Description of change

Chanapa 2021-06-27 at 04 43 10 PM

WooCommerce sends two emails to customer. One is sent when an order is placed with PayNow (Order on-hold email). Another one is sent when the order is paid (Processing order email). This PR removes QR from the second email.

Screenshots before the fix:

First email:
image

Second email:
image

3. Quality assurance

🔧 Environments:

  • WooCommerce: 5.4.1
  • WordPress: 5.7.2
  • PHP: 7.3.8
  • Omise-PHP: 2.13.0
  • Omise-WooCommerce: 4.8

✏️ Details:

  1. Enable PayNow on WordPress Admin.
  2. Set up webhook on Omise dashboard.
  3. Go to storefront, order and checkout with PayNow.
  4. Check the first email, it should contain QR.
  5. Mark the PayNow charge as paid.
  6. Check the second email, it should not contain QR.

4. Impact of the change

QR is removed from the second email.

First email:

image

Second email:

image

5. Priority of change

Normal

6. Additional Notes

n/a

@som-m som-m marked this pull request as ready for review June 27, 2021 09:52
@Jura-omise Jura-omise merged commit 333e583 into omise:master Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants